Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using mailcheck to help avoid typos in email addresses #14099

Open
timabbott opened this issue Mar 4, 2020 · 11 comments · May be fixed by #14634
Open

Consider using mailcheck to help avoid typos in email addresses #14099

timabbott opened this issue Mar 4, 2020 · 11 comments · May be fixed by #14634
Labels
area: onboarding help wanted

Comments

@timabbott
Copy link
Sponsor Member

timabbott commented Mar 4, 2020 •
edited

This issue is inspired by https://chat.zulip.org/#narrow/stream/9-issues/topic/Unable.20to.20create.20organization.20using.20zulipchat.2Ecom/near/826119, where a user typoed their email address while trying to create an account.

We don't want to be in the business of guessing which email addresses are likely typos, but apparently there's an OSS library that provides suggestions for common mistakes: https://github.com/mailcheck/mailcheck

It seems like integrating that in our various email address forms would be a nice improvement. I'd start with of course new account registration.

We might want to first look at whether there's a newer library that's not last updated in 2016, though.
@zulipbot
Copy link
Member

zulipbot commented Mar 4, 2020

Hello @zulip/server-onboarding members, this issue was labeled with the "area: onboarding" label, so you may want to check it out!

@SivaGanapathy98
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Mar 5, 2020

Welcome to Zulip, @SivaGanapathy98! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@zulipbot
Copy link
Member

zulipbot commented Mar 15, 2020 •
edited

Hello @SivaGanapathy98, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@ab1nash
Copy link
Collaborator

ab1nash commented Mar 19, 2020

I want to take it up in case @SivaGanapathy98 isn't working on it anymore

@ab1nash
Copy link
Collaborator

ab1nash commented Mar 19, 2020 •
edited

@timabbott it seems that the last commit on that repo is from 2016, but it feels pretty robust nevertheless.
Also, it seems pretty customizable. I think we should go ahead and try integrating it
I found some newer ones on the npm website. Check these out
email-butler
email-domain-check
Out of these, email-butler seems pretty neat to me.

@SivaGanapathy98
Copy link
Collaborator

@zulipbot claim

@SivaGanapathy98
Copy link
Collaborator

Hi @ab1nash . I have made changes using mailcheck plugin. I have created pull request for it. Thanks for your valuable suggestion.

@SivaGanapathy98 SivaGanapathy98 mentioned this issue Mar 19, 2020
Closed
@zulipbot
Copy link
Member

zulipbot commented Mar 30, 2020 •
edited

Hello @SivaGanapathy98, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

SivaGanapathy98 added a commit to SivaGanapathy98/zulip that referenced this issue Apr 1, 2020
@SivaGanapathy98
mailcheck: Add mailcheck feature to avoid typos in email address.
7af61d4 
Added mailcheck plugin into html file of signin page. Checks if the
user has typed the domain of email address correctly and suggests
new email address if misspelled, instead of creating new account.
Fixes zulip#14099.
SivaGanapathy98 added a commit to SivaGanapathy98/zulip that referenced this issue Apr 1, 2020
@SivaGanapathy98
css: Add style for email suggestion in signin page.
c36deed 
Added new css parameter for displaying email suggestions area
with several attributes for text in siginin page.
Fixes zulip#14099.
SivaGanapathy98 added a commit to SivaGanapathy98/zulip that referenced this issue Apr 2, 2020
@SivaGanapathy98
mailcheck: Add mailcheck feature to avoid typos in email address.
5852488 
Added mailcheck plugin into html file of signin page. Checks if the
user has typed the domain of email address correctly and suggests
new email address if misspelled, instead of creating new account.
Fixes zulip#14099.
SivaGanapathy98 added a commit to SivaGanapathy98/zulip that referenced this issue Apr 2, 2020
@SivaGanapathy98
css: Add style for email suggestion in signin page.
3f31ea6 
Added new css parameter for displaying email suggestions area
with several attributes for text in siginin page.
Fixes zulip#14099.
SivaGanapathy98 added a commit to SivaGanapathy98/zulip that referenced this issue Apr 2, 2020
@SivaGanapathy98
css: Add style for email suggestion in signin page.
ff9fe54 
Added new css parameter for displaying email suggestions area
with several attributes for text in siginin page.
Fixes zulip#14099.
SivaGanapathy98 added a commit to SivaGanapathy98/zulip that referenced this issue Apr 2, 2020
@SivaGanapathy98
css: Add style for email suggestion in signin page.
367464e 
Added new css parameter for displaying email suggestions area
with several attributes for text in siginin page.
Fixes zulip#14099.
@SivaGanapathy98
Copy link
Collaborator

@zulipbot claim

SivaGanapathy98 added a commit to SivaGanapathy98/zulip that referenced this issue Apr 13, 2020
@SivaGanapathy98
mailcheck: Add mailcheck feature to avoid typos in email address.
bb2d3b4 
Added mailcheck plugin into html file of signin page. Checks if the
user has typed the domain of email address correctly and suggests
new email address if misspelled, instead of creating new account.
Fixes zulip#14099.
SivaGanapathy98 added a commit to SivaGanapathy98/zulip that referenced this issue Apr 13, 2020
@SivaGanapathy98
css: Add style for email suggestion in signin page.
b5dd0cb 
Added new css parameter for displaying email suggestions area
with several attributes for text in siginin page.
Fixes zulip#14099.
@zulipbot
Copy link
Member

zulipbot commented Apr 14, 2020 •
edited

Hello @SivaGanapathy98, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

SivaGanapathy98 pushed a commit to SivaGanapathy98/zulip that referenced this issue Apr 18, 2020
@andersk @SivaGanapathy98
js: Add JavaScript files for email suggestion.
59f62ae 
Added mailcheck and jquery plugin files and email_suggestion
JavaScript file required for displaying suggestion for email.
Fixes zulip#14099.
SivaGanapathy98 added a commit to SivaGanapathy98/zulip that referenced this issue Apr 18, 2020
@SivaGanapathy98
mailcheck: Add mail check plugins into signin page html file.
e555a59 
Added necessary mailcheck plugins into this html file to
display email suggestion in sigin page.
Fixes zulip#14099.
SivaGanapathy98 added a commit to SivaGanapathy98/zulip that referenced this issue Apr 18, 2020
@SivaGanapathy98
css: Add style for email suggestion in signin page.
3bcb1f2 
Added new style parameters for displaying email
suggestion box with several attributes for font.
Fixes zulip#14099.
SivaGanapathy98 added a commit to SivaGanapathy98/zulip that referenced this issue Apr 18, 2020
@SivaGanapathy98
js: Add JavaScript file path in EXEMPT_FILES.
235524e 
Added three JavaScript file path into EXEMPT_FILES.
Fixes zulip#14099.
SivaGanapathy98 added a commit to SivaGanapathy98/zulip that referenced this issue Apr 18, 2020
@SivaGanapathy98
mailcheck: Add mail check plugins into signin page html file.
3f24050 
Added necessary mailcheck plugins into this html file to
display email suggestion in sigin page.
Fixes zulip#14099.
SivaGanapathy98 added a commit to SivaGanapathy98/zulip that referenced this issue Apr 18, 2020
@SivaGanapathy98
css: Add style for email suggestion in signin page.
697f1c1 
Added new style parameters for displaying email
suggestion box with several attributes for font.
Fixes zulip#14099.
SivaGanapathy98 added a commit to SivaGanapathy98/zulip that referenced this issue Apr 18, 2020
@SivaGanapathy98
js: Add JavaScript file path in EXEMPT_FILES.
585a075 
Added three JavaScript file path into EXEMPT_FILES.
Fixes zulip#14099.
SivaGanapathy98 added a commit to SivaGanapathy98/zulip that referenced this issue Apr 18, 2020
@SivaGanapathy98
js: Add JavaScript files for email suggestion.
eadfd71 
Added mailcheck and jquery plugin files and email_suggestion
JavaScript file required for displaying suggestion for email.
Fixes zulip#14099.
@SivaGanapathy98 SivaGanapathy98 linked a pull request Apr 18, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: onboarding help wanted
Projects
None yet
Milestone
No milestone
4 participants
@timabbott @zulipbot @ab1nash @SivaGanapathy98