Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

popovers: Improve keyboard navigation #15448

Closed
showell opened this issue Jun 18, 2020 · 2 comments
Closed

popovers: Improve keyboard navigation #15448

showell opened this issue Jun 18, 2020 · 2 comments
Assignees
@thedeveloperr
Labels
accessibility area: keyboard UI bug design in progress priority: high
Projects
Accessibility

Comments

@showell
Copy link
Contributor

showell commented Jun 18, 2020

When you open a popover (even with the mouse) from the left or right sidebar, we should keyboard-enable the popover by selecting the first field, which should allow for keyboard navigation.

See also #15439.
@thedeveloperr
Copy link
Collaborator

@zulipbot claim

This was referenced Jul 8, 2020
Closed
Open
@Gittenburg Gittenburg mentioned this issue Jul 10, 2020
Closed
2 tasks
thedeveloperr added a commit to thedeveloperr/zulip that referenced this issue Jul 10, 2020
@thedeveloperr
popovers: Add keyboard support for starred message popovers in sidebar.
0cdc3fb 
This commits focus the first anchor tag when starred messages popover in
left sidebar opens and also add arrow, vim_up/vim_down and enter hotkey
support for navigating the popover menu.

Fixes: zulip#15448.
thedeveloperr added a commit to thedeveloperr/zulip that referenced this issue Jul 10, 2020
@thedeveloperr
popovers: Add keyboard support for starred message popovers in sidebar.
fad11fe 
This commits focus the first anchor tag when starred messages popover in
left sidebar opens and also add arrow, vim_up/vim_down and enter hotkey
support for navigating the popover menu.

Fixes: zulip#15448.
@thedeveloperr
Copy link
Collaborator

#15722 solves this.

thedeveloperr added a commit to thedeveloperr/zulip that referenced this issue Jul 26, 2020
@thedeveloperr
popovers: Add keyboard support for starred message popovers in sidebar.
909f71c 
This commits focus the first anchor tag when starred messages popover in
left sidebar opens and also add arrow, vim_up/vim_down and enter hotkey
support for navigating the popover menu.

Fixes: zulip#15448.
@Gittenburg Gittenburg added this to in progress in Accessibility Jul 28, 2020
thedeveloperr added a commit to thedeveloperr/zulip that referenced this issue Aug 2, 2020
@thedeveloperr
popovers: Add keyboard support for starred message popovers in sidebar.
b9b4b9f 
This commits focus the first anchor tag when starred messages popover in
left sidebar opens and also add arrow, vim_up/vim_down and enter hotkey
support for navigating the popover menu.

Fixes: zulip#15448.
thedeveloperr added a commit to thedeveloperr/zulip that referenced this issue Aug 2, 2020
@thedeveloperr
user_info_popover_content: Replace href="#" with tabindex="0".
9b670c2 
Fixes: zulip#15448.
thedeveloperr added a commit to thedeveloperr/zulip that referenced this issue Aug 2, 2020
@thedeveloperr
user_info_popover_content: Replace href="#" with tabindex="0".
e215486 
Fixes: zulip#15448.
thedeveloperr added a commit to thedeveloperr/zulip that referenced this issue Aug 10, 2020
@thedeveloperr
user_info_popover_content: Replace href="#" with tabindex="0".
9eb0500 
Fixes: zulip#15448.
thedeveloperr added a commit to thedeveloperr/zulip that referenced this issue Aug 12, 2020
@thedeveloperr
user_info_popover_content: Replace href="#" with tabindex="0".
2db1051 
Fixes: zulip#15448.
Accessibility automation moved this from in progress to done Sep 1, 2020
sumanthvrao pushed a commit to sumanthvrao/zulip that referenced this issue Sep 3, 2020
@thedeveloperr @sumanthvrao
user_info_popover_content: Replace href="#" with tabindex="0".
3d0dcf2 
Fixes: zulip#15448.
Amitsinghyadav pushed a commit to Amitsinghyadav/zulip that referenced this issue Sep 20, 2020
@thedeveloperr @Amitsinghyadav
user_info_popover_content: Replace href="#" with tabindex="0".
7d97d57 
Fixes: zulip#15448.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thedeveloperr thedeveloperr

Labels
accessibility area: keyboard UI bug design in progress priority: high
Projects
Accessibility
  
done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

popovers: Improve keyboard navigation thedeveloperr/zulip
5 participants
@showell @timabbott @thedeveloperr @zulipbot @Gittenburg