Include stream privacy decorations in compose box, "move topic" dropdown, and similar UI widgets #19878
Comments
timabbott
added
help wanted
good first issue
area: compose (misc)
area: message-editing
area: general UI
priority: high
release goal
|
Hello @zulip/design, @zulip/server-compose, @zulip/server-message-view members, this issue was labeled with the "area: compose", "area: message-editing", "redesign" labels, so you may want to check it out! |
|
@zulipbot claim |
|
Welcome to Zulip, @noorbhtiti! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
|
@zulipbot still working on this :) |
Display the stream privacy icons (hash/lock/globe) in the compose box. Fixes part 1/2 of: zulip#19878
Display the stream privacy icons (hash/lock/globe) in the banner. Fixes part 2/2 of zulip#19878
|
@timabbott We are done here :) |
|
@noorbhtiti I don't see a pull request? |
|
Hello @noorbhtiti, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days. You can reclaim this issue or claim any other issue by commenting Thanks for your contributions, and hope to see you again soon! |
|
@zulipbot claim |
|
Welcome to Zulip, @HarshVardhan-Omar! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
|
Hello @HarshVardhan-Omar, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days. You can reclaim this issue or claim any other issue by commenting Thanks for your contributions, and hope to see you again soon! |
|
@zulipbot claim |
|
Welcome to Zulip, @srdeotarse! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
|
@zulipbot claim |
|
Welcome to Zulip, @cherish2003! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
|
@zulipbot claim |
|
Welcome to Zulip, @HimanshuKhatarkar! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
|
@zulipbot claim |
|
ERROR: Unexpected response from GitHub API. |
|
@zulipbot claim |
|
Welcome to Zulip, @ConnieLuksc! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
|
I will take a look, let me know if anyone is already working on this. |
…olicy banners. use the existing render_inline_decorated_stream_name (which displays appropriate stream icons) in composing banners. Fixes zulip#19878
…olicy banners. use the existing render_inline_decorated_stream_name (which displays appropriate stream icons) in composing banners. Fixes zulip#19878
…olicy banners. use the existing render_inline_decorated_stream_name (which displays appropriate stream icons) in composing banners. Fixes zulip#19878
…olicy banners. use the existing render_inline_decorated_stream_name (which displays appropriate stream icons) in composing banners. Fixes zulip#19878
get_message_header now calls render_inline_decorated_stream_name. The function returns html snippet which displays stream name with its icon. Changed the hbs files so the html snippet can be rendered correctly. Fixes zulip#19878
|
#29747 will fix this issue and is for review. |
get_message_header now calls render_inline_decorated_stream_name. The function returns html snippet which displays stream name with its icon. Changed the hbs files so the html snippet can be rendered correctly and the icon is closer to the stream name. Fixes zulip#19878
|
The icons described here have been implemented. See #25257 for what remains. |
Currently, we don't display the stream privacy icons (hash/lock/globe), either in the compose box or in a few related components like the "Move topic" menu accessible when editing messages. Here's the current compose look:
I'm not entirely sure that a straightforward version of adding the stream privacy decorations in those stream color blocks will look good, but it definitely seems worth trying, as that's the best way to find out.
Original chat.zulip.org conversation here: https://chat.zulip.org/#narrow/stream/9-issues/topic/missing.20hash.20before.20stream.20name/near/1255685
The text was updated successfully, but these errors were encountered: