Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate "Include organization name in subject of message notification emails" setting #19905

Closed
alya opened this issue Oct 5, 2021 · 10 comments · Fixed by #24075
Closed

Automate "Include organization name in subject of message notification emails" setting #19905

alya opened this issue Oct 5, 2021 · 10 comments · Fixed by #24075

Comments

@alya
Copy link
Contributor

alya commented Oct 5, 2021

Under Settings > Notifications, there is a checkbox setting for whether to "Include organization name in subject of message notification emails". This setting may be difficult to discover when it becomes relevant, however.

For Zulip Cloud users, we can actually make a good guess for the option that will be the best experience for the users. As we say on the help page: "If you belong to multiple Zulip organizations, it can be helpful to have the name of the organization in the subject line of your message notification emails."

We should add an option to automatically select whether the organization name is included in the subject.

Details:

  1. Replace the checkbox setting with a dropdown: Automatic [default], Yes, No
  2. The Automatic option should include the org name if, and only if, there are multiple Zulip organizations associated with the user's email.
  3. Edit the help page accordingly.

We may want to reset the option to "Automatic" for all current users who have not manually changed it.

@timabbott timabbott transferred this issue from zulip/zulip-mobile Oct 5, 2021
@zulipbot
Copy link
Member

zulipbot commented Oct 5, 2021

Hello @zulip/server-settings members, this issue was labeled with the "area: settings (user)" label, so you may want to check it out!

@timabbott
Copy link
Sponsor Member

At a database level, this means changing the relevant field from a boolean to an enum and then adjusting the UI.

@isakhagg
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Nov 2, 2021

@prakhar1144 You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

@isakhagg
Copy link
Collaborator

isakhagg commented Nov 2, 2021

I'm still working on this issue, just been busy with exams the last few days.

@isakhagg
Copy link
Collaborator

isakhagg commented Nov 4, 2021

@timabbott and @alya I have now done what I believe are the appropiate changes in the database. I do have a bit of a difficult time figuring out the next step. Are there any changes that needs to be done in the backend?

@isakhagg
Copy link
Collaborator

isakhagg commented Nov 5, 2021

@zulipbot abandon

@prakhar1144
Copy link
Member

@zulipbot claim

@prakhar1144
Copy link
Member

@alya

Before starting, I just want to confirm, since the issue is nearly 1 year old.
There is no change in the plan to handle this issue, right ?

Thanks.

@alya
Copy link
Contributor Author

alya commented Jan 10, 2023

Yep, everything still looks good to me -- thanks!

prakhar1144 added a commit to prakhar1144/zulip that referenced this issue Jan 14, 2023
…bject'.

Currently, there is a checkbox setting for whether to
"Include realm name in subject of message notification emails".

This commit replaces the checkbox setting with a dropdown:
Automatic [default], Yes, No

The Automatic option includes the realm name if, and only if,
there are multiple Zulip realms associated with the user's email.

Tests are added and(or) modified.

Fixes: zulip#19905.
prakhar1144 added a commit to prakhar1144/zulip that referenced this issue Jan 14, 2023
…bject'.

Currently, there is a checkbox setting for whether to
"Include realm name in subject of message notification emails".

This commit replaces the checkbox setting with a dropdown:
Automatic [default], Yes, No

The Automatic option includes the realm name if, and only if,
there are multiple Zulip realms associated with the user's email.

Tests are added and(or) modified.

Fixes: zulip#19905.
prakhar1144 added a commit to prakhar1144/zulip that referenced this issue Jan 14, 2023
…bject'.

Currently, there is a checkbox setting for whether to
"Include realm name in subject of message notification emails".

This commit replaces the checkbox setting with a dropdown:
Automatic [default], Yes, No

The Automatic option includes the realm name if, and only if,
there are multiple Zulip realms associated with the user's email.

Tests are added and(or) modified.

Fixes: zulip#19905.
prakhar1144 added a commit to prakhar1144/zulip that referenced this issue Jan 14, 2023
…bject'.

Currently, there is a checkbox setting for whether to
"Include realm name in subject of message notification emails".

This commit replaces the checkbox setting with a dropdown:
Automatic [default], Yes, No

The Automatic option includes the realm name if, and only if,
there are multiple Zulip realms associated with the user's email.

Tests are added and(or) modified.

Fixes: zulip#19905.
prakhar1144 added a commit to prakhar1144/zulip that referenced this issue Jan 15, 2023
…bject'.

Currently, there is a checkbox setting for whether to
"Include realm name in subject of message notification emails".

This commit replaces the checkbox setting with a dropdown:
Automatic [default], Yes, No

The Automatic option includes the realm name if, and only if,
there are multiple Zulip realms associated with the user's email.

Tests are added and(or) modified.

Fixes: zulip#19905.
prakhar1144 added a commit to prakhar1144/zulip that referenced this issue Jan 15, 2023
Currently, there is a checkbox setting for whether to
"Include realm name in subject of message notification emails".

This commit replaces the checkbox setting with a dropdown
having values: Automatic [default], Yes, No.

The Automatic option includes the realm name if, and only if,
there are multiple Zulip realms associated with the user's email.

Tests are added and(or) modified.

Fixes: zulip#19905.
prakhar1144 added a commit to prakhar1144/zulip that referenced this issue Jan 23, 2023
Currently, there is a checkbox setting for whether to
"Include realm name in subject of message notification emails".

This commit replaces the checkbox setting with a dropdown
having values: Automatic [default], Yes, No.

The Automatic option includes the realm name if, and only if,
there are multiple Zulip realms associated with the user's email.

Tests are added and(or) modified.

Fixes: zulip#19905.
prakhar1144 added a commit to prakhar1144/zulip that referenced this issue Jan 23, 2023
Currently, there is a checkbox setting for whether to
"Include realm name in subject of message notification emails".

This commit replaces the checkbox setting with a dropdown
having values: Automatic [default], Yes, No.

The Automatic option includes the realm name if, and only if,
there are multiple Zulip realms associated with the user's email.

Tests are added and(or) modified.

Fixes: zulip#19905.
prakhar1144 added a commit to prakhar1144/zulip that referenced this issue Jan 26, 2023
Currently, there is a checkbox setting for whether to
"Include realm name in subject of message notification emails".

This commit replaces the checkbox setting with a dropdown
having values: Automatic [default], Yes, No.

The Automatic option includes the realm name if, and only if,
there are multiple Zulip realms associated with the user's email.

Tests are added and(or) modified.

Fixes: zulip#19905.
prakhar1144 added a commit to prakhar1144/zulip that referenced this issue Jan 26, 2023
Currently, there is a checkbox setting for whether to
"Include realm name in subject of message notification emails".

This commit replaces the checkbox setting with a dropdown
having values: Automatic [default], Yes, No.

The Automatic option includes the realm name if, and only if,
there are multiple Zulip realms associated with the user's email.

Tests are added and(or) modified.

Fixes: zulip#19905.
prakhar1144 added a commit to prakhar1144/zulip that referenced this issue Feb 15, 2023
Currently, there is a checkbox setting for whether to
"Include realm name in subject of message notification emails".

This commit replaces the checkbox setting with a dropdown
having values: Automatic [default], Yes, No.

The Automatic option includes the realm name if, and only if,
there are multiple Zulip realms associated with the user's email.

Tests are added and(or) modified.

Fixes: zulip#19905.
prakhar1144 added a commit to prakhar1144/zulip that referenced this issue Feb 15, 2023
Currently, there is a checkbox setting for whether to
"Include realm name in subject of message notification emails".

This commit replaces the checkbox setting with a dropdown
having values: Automatic [default], Yes, No.

The Automatic option includes the realm name if, and only if,
there are multiple Zulip realms associated with the user's email.

Tests are added and(or) modified.

Fixes: zulip#19905.
prakhar1144 added a commit to prakhar1144/zulip that referenced this issue Feb 15, 2023
Currently, there is a checkbox setting for whether to
"Include realm name in subject of message notification emails".

This commit replaces the checkbox setting with a dropdown
having values: Automatic [default], Yes, No.

The Automatic option includes the realm name if, and only if,
there are multiple Zulip realms associated with the user's email.

Tests are added and(or) modified.

Fixes: zulip#19905.
prakhar1144 added a commit to prakhar1144/zulip that referenced this issue Feb 24, 2023
Currently, there is a checkbox setting for whether to
"Include realm name in subject of message notification emails".

This commit replaces the checkbox setting with a dropdown
having values: Automatic [default], Yes, No.

The Automatic option includes the realm name if, and only if,
there are multiple Zulip realms associated with the user's email.

Tests are added and(or) modified.

Fixes: zulip#19905.
prakhar1144 added a commit to prakhar1144/zulip that referenced this issue Feb 24, 2023
Currently, there is a checkbox setting for whether to
"Include realm name in subject of message notification emails".

This commit replaces the checkbox setting with a dropdown
having values: Automatic [default], Yes, No.

The Automatic option includes the realm name if, and only if,
there are multiple Zulip realms associated with the user's email.

Tests are added and(or) modified.

Fixes: zulip#19905.
prakhar1144 added a commit to prakhar1144/zulip that referenced this issue Feb 26, 2023
Currently, there is a checkbox setting for whether to
"Include realm name in subject of message notification emails".

This commit replaces the checkbox setting with a dropdown
having values: Automatic [default], Always, Never.

The Automatic option includes the realm name if, and only if,
there are multiple Zulip realms associated with the user's email.

Tests are added and(or) modified.

Fixes: zulip#19905.
prakhar1144 added a commit to prakhar1144/zulip that referenced this issue Mar 5, 2023
Currently, there is a checkbox setting for whether to
"Include realm name in subject of message notification emails".

This commit replaces the checkbox setting with a dropdown
having values: Automatic [default], Always, Never.

The Automatic option includes the realm name if, and only if,
there are multiple Zulip realms associated with the user's email.

Tests are added and(or) modified.

Fixes: zulip#19905.
prakhar1144 added a commit to prakhar1144/zulip that referenced this issue Mar 9, 2023
Currently, there is a checkbox setting for whether to
"Include realm name in subject of message notification emails".

This commit replaces the checkbox setting with a dropdown
having values: Automatic [default], Always, Never.

The Automatic option includes the realm name if, and only if,
there are multiple Zulip realms associated with the user's email.

Tests are added and(or) modified.

Fixes: zulip#19905.
prakhar1144 added a commit to prakhar1144/zulip that referenced this issue Mar 9, 2023
Currently, there is a checkbox setting for whether to
"Include realm name in subject of message notification emails".

This commit replaces the checkbox setting with a dropdown
having values: Automatic [default], Always, Never.

The Automatic option includes the realm name if, and only if,
there are multiple Zulip realms associated with the user's email.

Tests are added and(or) modified.

Fixes: zulip#19905.
prakhar1144 added a commit to prakhar1144/zulip that referenced this issue Mar 9, 2023
Currently, there is a checkbox setting for whether to
"Include realm name in subject of message notification emails".

This commit replaces the checkbox setting with a dropdown
having values: Automatic [default], Always, Never.

The Automatic option includes the realm name if, and only if,
there are multiple Zulip realms associated with the user's email.

Tests are added and(or) modified.

Fixes: zulip#19905.
timabbott pushed a commit to prakhar1144/zulip that referenced this issue Mar 15, 2023
Currently, there is a checkbox setting for whether to
"Include realm name in subject of message notification emails".

This commit replaces the checkbox setting with a dropdown
having values: Automatic [default], Always, Never.

The Automatic option includes the realm name if, and only if,
there are multiple Zulip realms associated with the user's email.

Tests are added and(or) modified.

Fixes: zulip#19905.
timabbott pushed a commit that referenced this issue Mar 15, 2023
Currently, there is a checkbox setting for whether to
"Include realm name in subject of message notification emails".

This commit replaces the checkbox setting with a dropdown
having values: Automatic [default], Always, Never.

The Automatic option includes the realm name if, and only if,
there are multiple Zulip realms associated with the user's email.

Tests are added and(or) modified.

Fixes: #19905.
himanshusuryawanshi pushed a commit to himanshusuryawanshi/zulip that referenced this issue Mar 16, 2023
Currently, there is a checkbox setting for whether to
"Include realm name in subject of message notification emails".

This commit replaces the checkbox setting with a dropdown
having values: Automatic [default], Always, Never.

The Automatic option includes the realm name if, and only if,
there are multiple Zulip realms associated with the user's email.

Tests are added and(or) modified.

Fixes: zulip#19905.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants