Add an option for whether to receive a direct message when invited users join #20398

xeruf · 2021-11-30T09:03:31Z

This issue description has been updated by @alya to include a specific design and by @laurynmm for the change from "private message" to "direct message" in the UI.

At present, when a user's invitation to Zulip is accepted, they receive a direct message announcing this. However, some users may not want to receive such a message, e.g. because they are already following new user notifications in a stream, or they simply don't need to know when new users join.

To address this, we should add a feature to turn off direct message notifications when sending an invitation. In particular, the user invite modal should have the following checkbox below the Emails text box:

[ ] Send me a direct message when my invitation is accepted.

Notes:

The checkbox should default to the previous state, which in turn defaults to enabled.
The checkbox should only be shown when inviting by email, not when creating an invite link. (We don't send notifications when invite links are used.)
If a user flips back and forth between inviting by email and generating a link, the current state of the checkbox should be preserved.

Original issue:

Allow Muting Notification Bot
I am annoyed that I get double-notified when a new user joins:
Through the channel topic for new users and a PM from the notification bot, as I am personally responsible for invitations.
I checked out Mute a User and https://docs.zulip.com/help/configure-notification-bot, but neither applies to PMs from the Notification Bot...

timabbott · 2021-12-01T20:48:14Z

@xeruf thanks for the report! I think don't think muting the notification bot is the right solution for this problem since it might disable other notifications you want; instead I think a personal notification setting for whether you get a PM when a new user joins who you invited makes more sense.

@alya thoughts on that design question?

zulipbot · 2021-12-05T00:01:56Z

Hello @JoshuaPius!

Thanks for your interest in Zulip! You have attempted to claim an issue without the labels "help wanted", "good first issue". Since you're a new contributor, you can only claim and submit pull requests for issues with the help wanted or good first issue labels.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

yashd26 · 2022-01-07T15:41:26Z

@zulipbot claim

zulipbot · 2022-01-07T15:41:34Z

Hello @algo-byte, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

yashd26 · 2022-01-20T17:21:58Z

@alya can you please tell me if this issue is open to work on?

alya · 2022-01-21T01:25:30Z

@algo-byte This issue wasn't really ready, as we didn't have a worked out design.

In particular, I think the right approach is to ask the user when they send the invitation, rather than making it a display setting.

alya · 2022-01-21T01:26:20Z

I can write up a description soon and mark it as "help wanted" at that point.

yashd26 · 2022-01-21T04:07:40Z

Thank you for confirming, will make sure to check out the labels first before working on any issue next time.

yashd26 · 2022-01-21T04:10:45Z

@sahil839 thank you so much for helping me on this issue. Learned a lot from you and from this issue.

alya · 2022-01-21T20:02:07Z

I've updated the issue, so it's ready to be worked on now.

yashd26 · 2022-01-22T14:27:33Z

@alya does that mean that for every invitee, the referrer can decide if he/she wants a PM or not?

xeruf · 2022-01-23T13:11:25Z

Little design annotation:

The checkbox should default to the previous state, which in turn defaults to enabled ~~on by default~~.

yashd26 · 2022-01-25T17:56:34Z

@zulipbot claim

alya · 2022-01-25T23:48:01Z

@algo-byte Not for every invitee, but every time the user is sending out a bundle of invites. If you want to get a message when A joins but not B, you'd have to invite them separately.

alya · 2022-01-25T23:49:21Z

Little design annotation:

The checkbox should default to the previous state, which in turn defaults to enabled ~~on by default~~.

Good idea, thanks! Updated accordingly.

If the implementation for this is complicated, we can discuss whether it's worth maintaining the state information. CC @timabbott

yashd26 · 2022-01-27T08:46:10Z

@alya does this look good?

yashd26 · 2022-01-27T21:05:24Z

@alya @timabbott I am having a little difficulty in preserving the default state of the checkbox. I tried finding the event handler that opens and closes user invite modal but couldn't find it. Also tried finding the #/invite url that gets called when we open the user invite modal but I am unable to find the right files. Any help is greatly appreciated.

alya · 2022-01-28T06:31:18Z

The screenshot looks good to me!

For the question above, you should post it in the #backend stream on chat.zulip.org so that more people have a chance to see it an help you out.

Everytime an invitee joins any realm the referrer is informed about invitee joining the realm through private message. This commit adds a checkbox at invite modal which allows the user to choose whether or not to get that private message. For that a new `receive_private_message_on_invitee_signup` field is added to user_ notification_setting. Fixes: zulip#20398

Previously, when a user's invitations were accepted, they got notification from welcome bot. However some user may not want this everytime. Presently, there is a personal notification setting which lets you decide if you want notification. Fixes: zulip#20398.

…ations. Previously, when a referrer's invitation to Zulip was accepted, they got a notification from notification-bot indicating their invitation has been accepted. This commit adds an option for referrer to decide whether he wants to receive the direct notification from the notification-bot. Fixes: zulip#20398

…bot. Previously, when a referrer's invitation to Zulip was accepted, they got a notification from notification-bot indicating their invitation has been accepted. This commit adds an option for referrer to decide whether he wants to receive the direct notification from the notification-bot. Fixes: zulip#20398

Previously, when a referrer's invitation to Zulip was accepted, they got a notification from notification-bot indicating their invitation has been accepted. This commit adds an option for referrer to decide whether he wants to receive the direct notification from the notification-bot. Fixes: zulip#20398

alya added the area: bots label Nov 30, 2021

timabbott added area: notifications (messages) priority: high and removed area: bots labels Dec 1, 2021

This was referenced Jan 9, 2022

[WIP]setting: add checkbox for allow PM when invitee signup #20735

Closed

[WIP]settings: add checkbox for allow PM when invitee signup #20796

Closed

alya changed the title ~~Allow Muting Notification Bot~~ Add an option for whether to receive a PM when invited users join Jan 21, 2022

alya added the help wanted label Jan 21, 2022

zulipbot assigned yashd26 Jan 25, 2022

zulipbot added the in progress label Jan 25, 2022

timabbott closed this as completed in #28819 Jul 6, 2024

timabbott closed this as completed in 4cce94b Jul 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add an option for whether to receive a direct message when invited users join #20398

Add an option for whether to receive a direct message when invited users join #20398

xeruf commented Nov 30, 2021 •

edited by alya

Loading

timabbott commented Dec 1, 2021 •

edited

Loading

zulipbot commented Dec 5, 2021

yashd26 commented Jan 7, 2022

zulipbot commented Jan 7, 2022

yashd26 commented Jan 20, 2022

alya commented Jan 21, 2022

alya commented Jan 21, 2022

yashd26 commented Jan 21, 2022

yashd26 commented Jan 21, 2022

alya commented Jan 21, 2022

yashd26 commented Jan 22, 2022

xeruf commented Jan 23, 2022

yashd26 commented Jan 25, 2022

alya commented Jan 25, 2022

alya commented Jan 25, 2022 •

edited

Loading

yashd26 commented Jan 27, 2022

yashd26 commented Jan 27, 2022

alya commented Jan 28, 2022

Add an option for whether to receive a direct message when invited users join #20398

Add an option for whether to receive a direct message when invited users join #20398

Comments

xeruf commented Nov 30, 2021 • edited by alya Loading

timabbott commented Dec 1, 2021 • edited Loading

zulipbot commented Dec 5, 2021

yashd26 commented Jan 7, 2022

zulipbot commented Jan 7, 2022

yashd26 commented Jan 20, 2022

alya commented Jan 21, 2022

alya commented Jan 21, 2022

yashd26 commented Jan 21, 2022

yashd26 commented Jan 21, 2022

alya commented Jan 21, 2022

yashd26 commented Jan 22, 2022

xeruf commented Jan 23, 2022

yashd26 commented Jan 25, 2022

alya commented Jan 25, 2022

alya commented Jan 25, 2022 • edited Loading

yashd26 commented Jan 27, 2022

yashd26 commented Jan 27, 2022

alya commented Jan 28, 2022

xeruf commented Nov 30, 2021 •

edited by alya

Loading

timabbott commented Dec 1, 2021 •

edited

Loading

alya commented Jan 25, 2022 •

edited

Loading