Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A lot of the shell scripts in this repo still don't have set -u and set -o pipefail enabled #20748

Open
rht opened this issue Jan 11, 2022 · 8 comments

Comments

@rht
Copy link
Collaborator

rht commented Jan 11, 2022

For shell hygiene.

@gnprice
Copy link
Member

gnprice commented Jan 11, 2022

(Chat discussion here and above.)

@zulipbot
Copy link
Member

Hello @zulip/server-tooling members, this issue was labeled with the "area: tooling" label, so you may want to check it out!

@InfiniteVerma

This comment has been minimized.

@zulipbot

This comment has been minimized.

@alexmv

This comment has been minimized.

@zulipbot
Copy link
Member

Hello @ailyas19776, it looks like we've already sent you a collaboration invite at https://github.com/zulip/zulip/invitations, but you haven't accepted it yet!

Please accept the invite and try to claim this issue again afterwards. We look forward to your contributions!

@ailyas19776
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Hello @ailyas19776, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants