Fix-#20844:Styles-Fixed overlapping of text on closing button. #20845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Pr Resolved the issue of overlapping text on the closing button.There were a lot of style changes which are confined to the search Only. Fixes-zulip#20844
|
@timabbott need your review. |
|
Heads up @Biki-das, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
timabbott
force-pushed
the
main
branch
2 times, most recently
from
4ec3636
to
88b200c
Compare
|
Closing as the original issue was completed in #20063. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr Resolved the issue of overlapping text on the closing button.There were a lot of style changes which are confined to the
search Only.
Fixes-#20844
I have made good amount of css changes, so this has affected a few styles, lookig forward to maintainer reviews, if there any conflicting styles and changes to be made.
Below is the output after making these changes
design.-.Zulip.Dev.-.Zulip.-.Google.Chrome.2022-01-19.20-31-49.mp4