Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The /poll widget does not support emoji display. #21674

Open
Tracked by #21917
Carnage78 opened this issue Apr 4, 2022 · 11 comments
Open
Tracked by #21917

The /poll widget does not support emoji display. #21674

Carnage78 opened this issue Apr 4, 2022 · 11 comments
Labels
area: emoji Emoji in markup, emoji reactions, emoji picker, etc. area: message feed (display) Web frontend rendering of messages (post markdown) help wanted

Comments

@Carnage78
Copy link

The /poll widget displays the emoji text, not the emoji image.
In preview mode:
image
result in:
image

@aparna-bhatt
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Apr 4, 2022

Hello @aparna-bhatt, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

@sayamsamal
Copy link
Collaborator

@zulipbot claim

@alya alya added help wanted area: emoji Emoji in markup, emoji reactions, emoji picker, etc. area: message feed (display) Web frontend rendering of messages (post markdown) labels Apr 4, 2022
@zulipbot
Copy link
Member

zulipbot commented Apr 4, 2022

Hello @zulip/server-emoji members, this issue was labeled with the "area: emoji" label, so you may want to check it out!

@zulipbot
Copy link
Member

Hello @sayamsamal, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for 10 days. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 4 days.

If you've decided to work on something else, simply comment @zulipbot abandon so that someone else can claim it and continue from where you left off.

Thank you for your valuable contributions to Zulip!

@sayamsamal
Copy link
Collaborator

I plan on working on this issue as part of GSOC '22.

@alya
Copy link
Contributor

alya commented Apr 19, 2022

@sayamsamal If you aren't actively working on it (I think you've got a few higher-priority issues on your plate?), you can go ahead an unassign yourself. We don't expect folks to work precisely on the issues they put in their GSoC proposal, and it's best to leave issues open unless you're actively working on them, in case someone else would like to pick it up. You can always help by reviewing another contributor's work as well. Thanks!

@sayamsamal
Copy link
Collaborator

@alya thank you for the guidance and clarification, I'll unassign myself from the issue for others to take up.

@sayamsamal
Copy link
Collaborator

@zulipbot abandon

@sayamsamal
Copy link
Collaborator

sayamsamal commented Apr 19, 2022

For anyone picking up this issue, I'd like to leave some notes.

  1. The issue is not only related to emojis but to the complete markdown, meaning none of the markdown is rendered in the poll widget.
  2. For knowledge on how to handle the markdown, please refer to https://zulip.readthedocs.io/en/latest/subsystems/markdown.html to know about the markdown implementation being used by Zulip.

@alya
Copy link
Contributor

alya commented Apr 26, 2022

Thanks! Yeah, I don't think we have short-term plans to solve the general problem, but anyone working on this should also consider fixing #12947 and #16821.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: emoji Emoji in markup, emoji reactions, emoji picker, etc. area: message feed (display) Web frontend rendering of messages (post markdown) help wanted
Projects
None yet
Development

No branches or pull requests

5 participants