<time> mention not working inside poll #16821
Comments
ultra-sonic
changed the title
|
@zulipbot claim |
|
I'll work on this issue with @Alexander3312 |
|
@zulipbot claim |
|
Hello @dineshssdn-867, it looks like someone has already claimed this issue! Since we believe multiple assignments to the same issue may cause some confusion, we encourage you to search for other unclaimed issues to work on. However, you can always reclaim this issue if no one is working on it. We look forward to your valuable contributions! |
|
Hello @Alexander3312, @Haunui, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for 10 days. Are you still working on this issue? If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 4 days. If you've decided to work on something else, simply comment Thank you for your valuable contributions to Zulip! |
|
@zulipbot claim |
|
Hello @GenRok1729, it looks like someone has already claimed this issue! Since we believe multiple assignments to the same issue may cause some confusion, we encourage you to search for other unclaimed issues to work on. However, you can always reclaim this issue if no one is working on it. We look forward to your valuable contributions! |
|
@zulipbot still working |
|
@zulipbot claim |
|
Welcome to Zulip, @JacobRoddam! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
|
So I claimed this as my first issue because I figured this was something I could figure out, but I am a little confused. I've been able to recreate the bug on the web app, but I'm confused as to what time notation this is and how it is generally parsed within zulip. Thank you |
|
Did some research and I understand the format, my question now is whether this should convert the time to the viewer's time zone |
|
#12947 is closely related here. Basically, we don't do any markdown conversions for poll items. We have a JS-side markdown parser, but we probably don't want to support every possible feature of markdown for poll items. Instead, we probably want basic things like bold, italics, and links. And then the time widget makes sense, too, since scheduling is a pretty compelling use case for the poll. |
|
@zulipbot claim |
|
@hackerkid Just linked my pull request. This is the first PR I've made with zulip so please let me know if there's anything I need to fix or do differently when creating a PR with zulip. |
The time widget markdown parser is added to poll question header. This is done giving a `marked` question value to the poll question header and upon updating the elements using `rendered_markdown`, the `<time>` tags get updated accordingly. The `poll_widget` test file is modified to incorporate markdown processing. Fixes zulip#16821
Time widget markdown parser functionality added to poll question header. The change is brought about by applying `update_elements` function on the poll question header.And in `rendered_markdown.js` a parsing function is added to render the timestamp Fixes zulip#16821
The time widget markdown parser is added to poll question header. This is done giving a `marked` question value to the poll question header and upon updating the elements using `rendered_markdown`, the `<time>` tags get updated accordingly. Fixes zulip#16821
The time widget markdown parser is added to poll question header. This is done giving a `marked` question value to the poll question header and upon updating the elements using `rendered_markdown`, the `<time>` tags get updated accordingly. The `poll_widget` test file is modified to incorporate markdown processing. Fixes zulip#16821
Time widget markdown parser functionality added to poll question header. The change is brought about by applying `update_elements` function on the poll question header.And in `rendered_markdown.js` a parsing function is added to render the timestamp Fixes zulip#16821
The time widget markdown parser is added to poll question header. This is done giving a `marked` question value to the poll question header and upon updating the elements using `rendered_markdown`, the `<time>` tags get updated accordingly. Fixes zulip#16821
The time widget markdown parser is added to poll question header. This is done giving a `marked` question value to the poll question header and upon updating the elements using `rendered_markdown`, the `<time>` tags get updated accordingly. The `poll_widget` test file is modified to incorporate markdown processing. Fixes zulip#16821
Time widget markdown parser functionality added to poll question header. The change is brought about by applying `update_elements` function on the poll question header.And in `rendered_markdown.js` a parsing function is added to render the timestamp Fixes zulip#16821
The time widget markdown parser is added to poll question header. This is done giving a `marked` question value to the poll question header and upon updating the elements using `rendered_markdown`, the `<time>` tags get updated accordingly. Fixes zulip#16821
The time widget markdown parser is added to poll question header. This is done giving a `marked` question value to the poll question header and upon updating the elements using `rendered_markdown`, the `<time>` tags get updated accordingly. The `poll_widget` test file is modified to incorporate markdown processing. Fixes zulip#16821
The time widget markdown parser is added to poll question header. This is done giving a `marked` question value to the poll question header and upon updating the elements using `rendered_markdown`, the `<time>` tags get updated accordingly. The `poll_widget` test file is modified to incorporate markdown processing. Fixes zulip#16821 poll time widget: Add time widget markdown parser to polls Time widget markdown parser functionality added to poll question header. The change is brought about by applying `update_elements` function on the poll question header.And in `rendered_markdown.js` a parsing function is added to render the timestamp Fixes zulip#16821 [Poll Time Widget] Add time widget markdown parser to poll question The time widget markdown parser is added to poll question header. This is done giving a `marked` question value to the poll question header and upon updating the elements using `rendered_markdown`, the `<time>` tags get updated accordingly. Fixes zulip#16821 [Poll Time Widget] Add time widget markdown parser to poll question The time widget markdown parser is added to poll question header. This is done giving a `marked` question value to the poll question header and upon updating the elements using `rendered_markdown`, the `<time>` tags get updated accordingly. The `poll_widget` test file is modified to incorporate markdown processing. Fixes zulip#16821 Remove unused-vars Fixes zulip#16821 Fixed linting issue in `poll_widget.js` Fixes zulip#16821
The time widget markdown parser is added to poll question header. This is done giving a `marked` question value to the poll question header and upon updating the elements using `rendered_markdown`, the `<time>` tags get updated accordingly. The `poll_widget` test file is modified to incorporate markdown processing. Fixes zulip#16821 poll time widget: Add time widget markdown parser to polls Time widget markdown parser functionality added to poll question header. The change is brought about by applying `update_elements` function on the poll question header.And in `rendered_markdown.js` a parsing function is added to render the timestamp Fixes zulip#16821 [Poll Time Widget] Add time widget markdown parser to poll question The time widget markdown parser is added to poll question header. This is done giving a `marked` question value to the poll question header and upon updating the elements using `rendered_markdown`, the `<time>` tags get updated accordingly. Fixes zulip#16821 [Poll Time Widget] Add time widget markdown parser to poll question The time widget markdown parser is added to poll question header. This is done giving a `marked` question value to the poll question header and upon updating the elements using `rendered_markdown`, the `<time>` tags get updated accordingly. The `poll_widget` test file is modified to incorporate markdown processing. Fixes zulip#16821 Remove unused-vars Fixes zulip#16821 Fixed linting issue in `poll_widget.js` Fixes zulip#16821
alya
added
area: widgets
Hi there,
this does not work for me:
/poll Find a time
<time:2020-12-02T14:00:00+01:00>
<time:2020-12-02T15:00:00+01:00>
would be great to have timezone support in polls for finding a meeting time
thanks in advance
Oliver
The text was updated successfully, but these errors were encountered: