Communicate upfront when user is not allowed to send a DM #21896

alya · 2022-04-22T21:51:04Z

[updated Apr 2023]

At present, when a user is not allowed to send a DM, we notify them via a banner after the "Send" button is pressed:

This can cause frustration, as the user may have spent some time composing the message.

Instead, if a user does not have permission to send a DM message, we should:

Change the banner text to: "You are not allowed to send direct messages in this organization."
Show the banner immediately whenever a DM addressee is selected that the user is not allowed to send a DM to. (See comment below.)
Disable the "Send" button.
Show a tooltip on the "Send" button with the same content as the banner.

CZO discussion 1
CZO discussion 2

For stream messages, the corresponding issue is tracked as #25219.

karanka · 2022-04-22T22:37:45Z

@alya would this be in the message_send.py?

yashd26 · 2022-04-24T15:28:47Z

Hey @karanka, are you working on this issue?

manila · 2022-04-27T07:00:30Z

@zulipbot claim

zulipbot · 2022-04-27T07:00:41Z

Hello @manila, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

manila · 2022-04-27T07:16:42Z

I'd like to work on this issue if possible (my other issue is pending further discussion). There are two considerations that seem important when solving this:

Private Messages are allowed for bots when PM's are disabled org wide and thus shouldn't be stopped
Private Messages to other users should be stopped early when PM's are disabled in the org and so we should receive an error as soon as it's clear an individual user is being included when composing a message

My proposal for this might look something like this:

Feedback and ideas welcome! My initial thought is that only using a tooltip on the send button could be easily overlooked. I think utilizing the compose warnings might be more effective especially if they can happen as soon as a user (not a bot) is added as a recipient

manila · 2022-05-01T08:04:45Z

@zulipbot claim

Fixes zulip#21896.

zulipbot · 2022-05-11T13:10:54Z

@manila You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

manila · 2022-05-11T20:57:31Z

Hello! PR #21971 is ready for review which may close this issue, as I understand it I would need to un-assign myself on this issue to formally claim another?

There could still be some discussion around this issue so I'll opt to stay on this one for now

alya · 2022-05-17T01:23:05Z

I would need to un-assign myself on this issue to formally claim another?

@manila yep, that's right, but please feel free to informally claim something with a comment while waiting for feedback here.

amanagr · 2022-05-17T02:20:40Z

@manila also note the new task at the end of issue description:

When a user is not allowed to send messages to a particular stream, disable the "Send" button when composing to that stream. Tooltip: "You are not allowed to send messages to #**stream name**." See CZO thread.

manila · 2022-05-17T02:27:24Z

Thank you for pointing out the updated issue description, I'll re-work my existing PR #21971 to meet these specs

medhatiwari · 2022-05-20T03:27:12Z

Hey @manila are you still working on the extended part of this issue?
If not would like to work on this!

manila · 2022-05-20T03:31:19Z

Hey @medhatiwari, thanks for checking in, I have been actively working on the updated issue and expect to submit an updated PR shortly. Did you have any additional ideas or comments that you thought might be helpful in regard to this issue?

Would you like to be tagged when I submit my PR as a peer reviewer?

medhatiwari · 2022-05-20T03:39:41Z

Hey @medhatiwari, thanks for checking in, I have been actively working on the updated issue and expect to submit an updated PR shortly. Did you have any additional ideas or comments that you thought might be helpful in regard to this issue?

Heya, I just wanted to confirm If I could contribute.

Would you like to be tagged when I submit my PR as a peer reviewer?

Yeah definitely, would love to see your work!

…rmissions. Fixes: zulip#21896

Disable send button if private messages are disabled and user is composing a message. Disable send button if user doesn't have permissions to send to stream when composing. Add frontend node tests for check_send_permissions and check_stream_send_permissions. Fixes: zulip#21896

palashb01 · 2023-03-08T03:48:13Z

Hey @manila , I noticed that the PR hasn't been updated recently. Are you still actively working on this issue, or should I take over?.

Joelute · 2023-04-18T04:02:20Z

@zulipbot claim

After the changes in zulip#25572, users were no longer able to start a direct message with bots if the organization disabled direct messages. However, we should allow direct messages to bots regardless of the policy because it's a useful interface for users to interact with various classes of bots. user_ids_string_to_ids_array was also modified to prevent cases where the split function returned an array of [0] rather than [] when dealing with a empty id string of "". Fixes: zulip#21896.

Previously, the text on the warning banner when the user is not allowed to direct message is "Direct messages are disabled in this organization.". While the text on the warning banner when the user is not allowed to send message to stream is "You do not have permission to post in this stream". These wording is inconsistent with each other and we should change it to keep them consistent and aligned with each other. Fixes: zulip#21896.

After the changes in zulip#25572, users were no longer able to start a direct message with bots if the organization disabled direct messages. However, we should allow direct messages to bots regardless of the policy because it's a useful interface for users to interact with various classes of bots. user_ids_string_to_ids_array was also modified to prevent cases where the split function returned an array of [0] rather than [] when dealing with a empty id string of "". Fixes: zulip#21896.

Previously, the text on the warning banner when the user is not allowed to direct message is "Direct messages are disabled in this organization.". While the text on the warning banner when the user is not allowed to send message to stream is "You do not have permission to post in this stream". These wording is inconsistent with each other and we should change it to keep them consistent and aligned with each other. Fixes: zulip#21896.

After the changes in zulip#25572, users were no longer able to start a direct message with bots if the organization disabled direct messages. However, we should allow direct messages to bots regardless of the policy because it's a useful interface for users to interact with various classes of bots. user_ids_string_to_ids_array was also modified to prevent cases where the split function returned an array of [0] rather than [] when dealing with a empty id string of "". Fixes: zulip#21896.

Previously, the text on the warning banner when the user is not allowed to direct message is "Direct messages are disabled in this organization.". While the text on the warning banner when the user is not allowed to send message to stream is "You do not have permission to post in this stream". These wording is inconsistent with each other and we should change it to keep them consistent and aligned with each other. Fixes: zulip#21896.

After the changes in zulip#25572, users were no longer able to start a direct message with bots if the organization disabled direct messages. However, we should allow direct messages to bots regardless of the policy because it's a useful interface for users to interact with various classes of bots. user_ids_string_to_ids_array was also modified to prevent cases where the split function returned an array of [0] rather than [] when dealing with a empty id string of "". Fixes: zulip#21896.

Previously, the text on the warning banner when the user is not allowed to direct message is "Direct messages are disabled in this organization.". While the text on the warning banner when the user is not allowed to send message to stream is "You do not have permission to post in this stream". These wording is inconsistent with each other and we should change it to keep them consistent and aligned with each other. Fixes: zulip#21896.

After the changes in #25572, users were no longer able to start a direct message with bots if the organization disabled direct messages. However, we should allow direct messages to bots regardless of the policy because it's a useful interface for users to interact with various classes of bots. user_ids_string_to_ids_array was also modified to prevent cases where the split function returned an array of [0] rather than [] when dealing with a empty id string of "". Fixes: #21896.

Previously, the text on the warning banner when the user is not allowed to direct message is "Direct messages are disabled in this organization.". While the text on the warning banner when the user is not allowed to send message to stream is "You do not have permission to post in this stream". These wording is inconsistent with each other and we should change it to keep them consistent and aligned with each other. Fixes: #21896.

After the changes in zulip#25572, users were no longer able to start a direct message with bots if the organization disabled direct messages. However, we should allow direct messages to bots regardless of the policy because it's a useful interface for users to interact with various classes of bots. user_ids_string_to_ids_array was also modified to prevent cases where the split function returned an array of [0] rather than [] when dealing with a empty id string of "". Fixes: zulip#21896.

Previously, the text on the warning banner when the user is not allowed to direct message is "Direct messages are disabled in this organization.". While the text on the warning banner when the user is not allowed to send message to stream is "You do not have permission to post in this stream". These wording is inconsistent with each other and we should change it to keep them consistent and aligned with each other. Fixes: zulip#21896.

After the changes in zulip#25572, users were no longer able to start a direct message with bots if the organization disabled direct messages. However, we should allow direct messages to bots regardless of the policy because it's a useful interface for users to interact with various classes of bots. user_ids_string_to_ids_array was also modified to prevent cases where the split function returned an array of [0] rather than [] when dealing with a empty id string of "". Fixes: zulip#21896.

Previously, the text on the warning banner when the user is not allowed to direct message is "Direct messages are disabled in this organization.". While the text on the warning banner when the user is not allowed to send message to stream is "You do not have permission to post in this stream". These wording is inconsistent with each other and we should change it to keep them consistent and aligned with each other. Fixes: zulip#21896.

After the changes in zulip#25572, users were no longer able to start a direct message with bots if the organization disabled direct messages. However, we should allow direct messages to bots regardless of the policy because it's a useful interface for users to interact with various classes of bots. user_ids_string_to_ids_array was also modified to prevent cases where the split function returned an array of [0] rather than [] when dealing with a empty id string of "". Fixes: zulip#21896.

Previously, the text on the warning banner when the user is not allowed to direct message is "Direct messages are disabled in this organization.". While the text on the warning banner when the user is not allowed to send message to stream is "You do not have permission to post in this stream". These wording is inconsistent with each other and we should change it to keep them consistent and aligned with each other. Fixes: zulip#21896.

alya added help wanted area: compose (misc) labels Apr 22, 2022

This was referenced Apr 22, 2022

help_docs: Update link in restrict-private-messages. #21684

Merged

Convert replies between stream and private messages #3409

Closed

manila mentioned this issue May 1, 2022

Disable send button when user doesn't have permissions to send message #21971

Closed

12 tasks

zulipbot assigned manila May 1, 2022

zulipbot added the in progress label May 1, 2022

manila added a commit to manila/zulip that referenced this issue May 1, 2022

compose.css: Add 'disabled' classes for send button and compose textarea

c3c41a2

Fixes zulip#21896.

manila added a commit to manila/zulip that referenced this issue May 1, 2022

compose.css: Add 'disabled' classes for send button and compose textarea

ac213d0

Fixes zulip#21896.

zulipbot unassigned manila May 16, 2022

zulipbot removed the in progress label May 16, 2022

manila added a commit to manila/zulip that referenced this issue May 23, 2022

compose_validate.js: Disable send button if user doesn't have send pe…

6e7a16a

…rmissions. Fixes: zulip#21896

manila added a commit to manila/zulip that referenced this issue May 23, 2022

compose_validate.js: Disable send button if user doesn't have send pe…

de280fa

…rmissions. Fixes: zulip#21896

manila added a commit to manila/zulip that referenced this issue May 29, 2022

compose_validate.js: Disable send button if user doesn't have send pe…

7ebd88b

…rmissions. Fixes: zulip#21896

manila added a commit to manila/zulip that referenced this issue Jun 10, 2022

compose_validate.js: Disable send button if user doesn't have send pe…

896ebb6

…rmissions. Fixes: zulip#21896

manila added a commit to manila/zulip that referenced this issue Jun 11, 2022

compose_validate.js: Disable send button if user doesn't have send pe…

c16294b

…rmissions. Fixes: zulip#21896

alya changed the title ~~Disable "Send" button when user is not allowed to send private messages~~ Disable "Send" button when user is not allowed to send a message Sep 26, 2022

zulipbot assigned Joelute Apr 18, 2023

zulipbot added the in progress label Apr 18, 2023

Joelute mentioned this issue Apr 20, 2023

Improve compose box UI for streams where user doesn't have posting permissions #25219

Closed

3 tasks

alya changed the title ~~Disable "Send" button when user is not allowed to send a message~~ Communicate upfront when user is not allowed to send a DM Apr 21, 2023

Joelute mentioned this issue Sep 6, 2023

compose: Allow the user to direct message bots despite of policy. #26650

Merged

12 tasks

timabbott added area: compose (banners & validation) Validation and banners in the compose box and removed area: compose (misc) labels Sep 19, 2023

timabbott closed this as completed in #26650 Sep 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Communicate upfront when user is not allowed to send a DM #21896

Communicate upfront when user is not allowed to send a DM #21896

alya commented Apr 22, 2022 •

edited

karanka commented Apr 22, 2022

yashd26 commented Apr 24, 2022

manila commented Apr 27, 2022

zulipbot commented Apr 27, 2022

manila commented Apr 27, 2022

manila commented May 1, 2022

zulipbot commented May 11, 2022 •

edited

manila commented May 11, 2022

alya commented May 17, 2022

amanagr commented May 17, 2022

manila commented May 17, 2022

medhatiwari commented May 20, 2022

manila commented May 20, 2022

medhatiwari commented May 20, 2022

palashb01 commented Mar 8, 2023

Joelute commented Apr 18, 2023

Communicate upfront when user is not allowed to send a DM #21896

Communicate upfront when user is not allowed to send a DM #21896

Comments

alya commented Apr 22, 2022 • edited

karanka commented Apr 22, 2022

yashd26 commented Apr 24, 2022

manila commented Apr 27, 2022

zulipbot commented Apr 27, 2022

manila commented Apr 27, 2022

manila commented May 1, 2022

zulipbot commented May 11, 2022 • edited

manila commented May 11, 2022

alya commented May 17, 2022

amanagr commented May 17, 2022

manila commented May 17, 2022

medhatiwari commented May 20, 2022

manila commented May 20, 2022

medhatiwari commented May 20, 2022

palashb01 commented Mar 8, 2023

Joelute commented Apr 18, 2023

alya commented Apr 22, 2022 •

edited

zulipbot commented May 11, 2022 •

edited