Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uneditable topic field should not be clickable #22565

Closed
alya opened this issue Jul 22, 2022 · 7 comments · Fixed by #22580 or #22765
Closed

Uneditable topic field should not be clickable #22565

alya opened this issue Jul 22, 2022 · 7 comments · Fixed by #22580 or #22765
Labels
area: message-editing bug

Comments

@alya
Copy link
Contributor

alya commented Jul 22, 2022

When a user can't edit the topic of the message, the edit/view source message view correctly shows a greyed out topic field. However, this field incorrectly has a click behavior. We should fix this.

Screen Shot 2022-07-21 at 11 36 55 PM

Screen Shot 2022-07-21 at 11 43 12 PM

CZO discussion
@zulipbot
Copy link
Member

Hello @zulip/server-message-view members, this issue was labeled with the "area: message-editing" label, so you may want to check it out!

@alya alya mentioned this issue Jul 22, 2022
Closed
@nelsonmic
Copy link

Hello there 😃, you could try using this cool bug reporting tool birdeatsbug to help you handle bug reports.

Get steps to reproduce
Logs
Clicks
Network errors
And you could share all of that here so that it's easy to see what happened and get to fixing it. Do check it out :-)

@madrix01
Copy link
Collaborator

@alya I'm working on this issue.

@jai2201
Copy link
Collaborator

jai2201 commented Jul 24, 2022

Had a talk with @madrix01 , since I already fixed #22565, so I'm picking up this too to fix on high-priority.

@jai2201
Copy link
Collaborator

jai2201 commented Jul 24, 2022

@zulipbot claim

jai2201 added a commit to jai2201/zulip that referenced this issue Jul 24, 2022
@jai2201
message-edit: Make uneditable topic field unclickable.
57b4d3a 
Currently when a user can't edit the topic of the message,
the edit/view source message view correctly shows a greyed
out topic field. However, this field incorrectly has a
click behavior which is fixed in this commit.

Fixes zulip#22565.
@jai2201 jai2201 mentioned this issue Jul 24, 2022
Merged
12 tasks
jai2201 added a commit to jai2201/zulip that referenced this issue Jul 24, 2022
@jai2201
message-edit: Make non editable topic field unclickable.
612d7a2 
Currently when a user can't edit the topic of the message,
the edit/view source message view correctly shows a greyed
out topic field. However, this field incorrectly has a
click behavior which is fixed in this commit.

Fixes zulip#22565.
jai2201 added a commit to jai2201/zulip that referenced this issue Jul 24, 2022
@jai2201
message-edit: Make non editable topic field unclickable.
c2aa562 
Currently when a user can't edit the topic of the message,
the edit/view source message view correctly shows a greyed
out topic field. However, this field incorrectly has a
click behavior which is fixed in this commit.

Fixes zulip#22565.
jai2201 added a commit to jai2201/zulip that referenced this issue Jul 24, 2022
@jai2201
message-edit: Make non editable topic field unclickable.
f2274a2 
Currently when a user can't edit the topic of the message,
the edit/view source message view correctly shows a greyed
out topic field. However, this field incorrectly has a
click behavior which is fixed in this commit.

Fixes zulip#22565.
jai2201 added a commit to jai2201/zulip that referenced this issue Jul 31, 2022
@jai2201
message-edit: Make non editable topic field unclickable.
571c1ce 
Currently when a user can't edit the topic of the message,
the edit/view source message view correctly shows a greyed
out topic field. However, this field incorrectly has a
click behavior which is fixed in this commit.

Fixes zulip#22565.
jai2201 added a commit to jai2201/zulip that referenced this issue Jul 31, 2022
@jai2201
message-edit: Make non editable topic field unclickable.
d8c115b 
Currently when a user can't edit the topic of the message,
the edit/view source message view correctly shows a greyed
out topic field. However, this field incorrectly has a
click behavior which is fixed in this commit.

Fixes zulip#22565.
jai2201 added a commit to jai2201/zulip that referenced this issue Jul 31, 2022
@jai2201
message-edit: Make non editable topic field unclickable.
a5f602c 
Currently when a user can't edit the topic of the message,
the edit/view source message view correctly shows a greyed
out topic field. However, this field incorrectly has a
click behavior which is fixed in this commit.

Fixes zulip#22565.
jai2201 added a commit to jai2201/zulip that referenced this issue Aug 7, 2022
@jai2201
message-edit: Make non editable topic field unclickable.
772c28f 
Currently when a user can't edit the topic of the message,
the edit/view source message view correctly shows a greyed
out topic field. However, this field incorrectly has a
click behavior which is fixed in this commit.

Fixes zulip#22565.
jai2201 added a commit to jai2201/zulip that referenced this issue Aug 11, 2022
@jai2201
message-edit: Make non editable topic field unclickable.
7ee1f17 
Currently when a user can't edit the topic of the message,
the edit/view source message view correctly shows a greyed
out topic field. However, this field incorrectly has a
click behavior which is fixed in this commit.

Fixes zulip#22565.
jai2201 added a commit to jai2201/zulip that referenced this issue Aug 12, 2022
@jai2201
message-edit: Make non editable topic field unclickable.
13373bd 
Currently when a user can't edit the topic of the message,
the edit/view source message view correctly shows a greyed
out topic field. However, this field incorrectly has a
click behavior which is fixed in this commit.

Fixes zulip#22565.
jai2201 added a commit to jai2201/zulip that referenced this issue Aug 21, 2022
@jai2201
message-edit: Make non editable topic field unclickable.
c9ec71c 
Currently when a user can't edit the topic of the message,
the edit/view source message view correctly shows a greyed
out topic field. However, this field incorrectly has a
click behavior which is fixed in this commit.

Fixes zulip#22565.
@jai2201 jai2201 mentioned this issue Aug 21, 2022
Merged
12 tasks
jai2201 added a commit to jai2201/zulip that referenced this issue Aug 21, 2022
@jai2201
message_edit: Use disabled instead of readonly to disable controls.
344f9fb 
Currently when a user does not have the permission to edit the topic/content
of a message, the edit UI/view source UI correctly shows a greyed
out topic/message-content input field, however these fields incorrectly have a
click behavior, so to fix this we now would want to use `disabled` prop instead
of `readonly` attribute as `readonly` controls can still function and are still
focusable whereas disabled controls can not receive focus and are unclickable.

Fixes zulip#22565.
@zulipbot
Copy link
Member

zulipbot commented Aug 31, 2022 •
edited
Loading

@jai2201 You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

timabbott pushed a commit that referenced this issue Sep 1, 2022
@jai2201 @timabbott
message_edit: Use disabled instead of readonly to disable controls.
73cfab8 
Currently when a user does not have the permission to edit the topic/content
of a message, the edit UI/view source UI correctly shows a greyed
out topic/message-content input field, however these fields incorrectly have a
click behavior, so to fix this we now would want to use `disabled` prop instead
of `readonly` attribute as `readonly` controls can still function and are still
focusable whereas disabled controls can not receive focus and are unclickable.

Fixes #22565.
@alya alya reopened this Sep 11, 2022
jai2201 added a commit to jai2201/zulip that referenced this issue Sep 28, 2022
@jai2201
message_edit: Use disabled instead of readonly to disable controls.
26453f3 
Currently when a user does not have the permission to edit the topic/content
of a message, the edit UI/view source UI correctly shows a greyed
out topic/message-content input field, however these fields incorrectly have a
click behavior, so to fix this we now would want to use `disabled` prop instead
of `readonly` attribute as `readonly` controls can still function and are still
focusable whereas disabled controls can not receive focus and are unclickable.

Fixes zulip#22565.
@jai2201 jai2201 mentioned this issue Sep 28, 2022
Closed
12 tasks
jai2201 added a commit to jai2201/zulip that referenced this issue Sep 28, 2022
@jai2201
message_edit: Use disabled instead of readonly to disable controls.
1745065 
Currently when a user does not have the permission to edit the topic
of a message, the edit UI/view source UI correctly shows a greyed
out topic input field, however this field incorrectly have a
click behavior, so to fix this we now would want to use `disabled` prop instead
of `readonly` attribute as `readonly` controls can still function and are still
focusable whereas disabled controls can not receive focus and are unclickable.

Fixes zulip#22565.
@alya alya removed the help wanted label Sep 30, 2022
@alya alya mentioned this issue Sep 30, 2022
Closed
5 tasks
@alya
Copy link
Contributor Author

alya commented Oct 12, 2022

This issue has been fixed via #23139.

@alya alya closed this as completed Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: message-editing bug
Projects
None yet
Milestone
No milestone
5 participants
@alya @zulipbot @madrix01 @nelsonmic @jai2201