Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear popovers on stream narrows #2281

Closed
showell opened this issue Nov 11, 2016 · 5 comments
Closed

Clear popovers on stream narrows #2281

showell opened this issue Nov 11, 2016 · 5 comments

Comments

@showell
Copy link
Contributor

showell commented Nov 11, 2016

If you narrow to stream A and open its popover menu, then click on stream B in the sidebar, the popover for stream A still sticks around. Generally, we solve this by calling popovers.hide_all(); at the start of various UI actions (or at the start of trigger event handlers). This should be an easy change, with the following minor challenges:

  • We want to avoid having lots of calls to popovers.hide_all() in our code, so we should be thoughtful about the best place to put these.
  • When you're manually testing this fix, you should try to uncover similar bugs by doing things like narrowing from the recipient bar, searching, opening up other menus, etc.
@jacklqiu
Copy link
Contributor

jacklqiu commented Dec 30, 2016

Don't know if this is related, but if you press the down chevron and scroll up or down. The popover doesn't exit.

@timabbott
Copy link
Sponsor Member

@540KJ I'm not sure I understand; can you post a screenshot or brief video?

@jacklqiu
Copy link
Contributor

jacklqiu commented Dec 30, 2016

As you can see, the popover doesn't belong to (no topic), but rather lorem ipsum. Obtained through opening popover and scrolling up.
scroll up

@timabbott
Copy link
Sponsor Member

Ahh, OK, yeah, that makes sense. Probably a totally independent issue from the clearing bug; can you open a new issue with that screenshot?

@timabbott
Copy link
Sponsor Member

I think this was fixed by #3088.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants