-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear popovers on stream narrows #2281
Comments
showell
pushed a commit
that referenced
this issue
Dec 20, 2016
SaumyaRawat
pushed a commit
to SaumyaRawat/zulip
that referenced
this issue
Dec 20, 2016
picapi
pushed a commit
to picapi/zulip
that referenced
this issue
Dec 22, 2016
Don't know if this is related, but if you press the down chevron and scroll up or down. The popover doesn't exit. |
@540KJ I'm not sure I understand; can you post a screenshot or brief video? |
Ahh, OK, yeah, that makes sense. Probably a totally independent issue from the clearing bug; can you open a new issue with that screenshot? |
I think this was fixed by #3088. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you narrow to stream A and open its popover menu, then click on stream B in the sidebar, the popover for stream A still sticks around. Generally, we solve this by calling
popovers.hide_all();
at the start of various UI actions (or at the start of trigger event handlers). This should be an easy change, with the following minor challenges:popovers.hide_all()
in our code, so we should be thoughtful about the best place to put these.The text was updated successfully, but these errors were encountered: