Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make linkfiers reorderable #23716

Closed
alya opened this issue Nov 30, 2022 · 12 comments · Fixed by #26464
Closed

Make linkfiers reorderable #23716

alya opened this issue Nov 30, 2022 · 12 comments · Fixed by #26464

Comments

@alya
Copy link
Contributor

alya commented Nov 30, 2022

When there are overlapping linkifiers, it should ideally be possible to reorder them to determine which one will take priority (i.e., the one that's listed higher).

In the settings UI, can use the same drag-and-drop approach as we do for custom profile fields.

This addresses a user pain point (discussed on CZO):

Our users creating the linkifiers were under the impression that there is an matching order for the linkifiers and only the first match matters. They even went for the trouble of recreating the linkifiers many times so that they got the "order correct".

@zulipbot
Copy link
Member

Hello @zulip/server-settings members, this issue was labeled with the "area: settings (admin/org)" label, so you may want to check it out!

@mpedro12
Copy link
Collaborator

mpedro12 commented Dec 1, 2022

hello I am interested in contributing to this issue.. for this particular issue, would it suffice to make the linkifier components drag and drop-able ?

@mpedro12
Copy link
Collaborator

mpedro12 commented Dec 1, 2022

@zulipbot claim

@alya
Copy link
Contributor Author

alya commented Dec 1, 2022

@mpedro12 No, the goal of this issue is that not only should they be drag-and-droppable, but their ordering should affect how the linkfiers are prioritized when a message is processed.

@mpedro12
Copy link
Collaborator

mpedro12 commented Dec 1, 2022

@zulipbot abandon

@ibrauf
Copy link
Collaborator

ibrauf commented Dec 1, 2022

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Dec 1, 2022

Welcome to Zulip, @ibrauf! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@zulipbot
Copy link
Member

zulipbot commented Dec 12, 2022

@ibrauf You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

@timabbott
Copy link
Sponsor Member

Now that #23715 is complete, the remaining work for this is essentially just setting the database model + settings experience ... and then changing the line changed by the first commit of #23715 to sort by the the precedence field rather than the ID.

@Ujjawal3
Copy link
Collaborator

Ujjawal3 commented Feb 8, 2023

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Feb 18, 2023

@Ujjawal3 You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

@PIG208
Copy link
Member

PIG208 commented Aug 10, 2023

@zulipbot claim

PIG208 added a commit to PIG208/zulip that referenced this issue Aug 10, 2023
This also removes sorting on the pattern and the URL template, because
it does not make sense anymore as we make linkifiers draggable.

Fixes zulip#23716
PIG208 added a commit to PIG208/zulip that referenced this issue Aug 10, 2023
This also removes sorting on the pattern and the URL template, because
it does not make sense anymore as we make linkifiers draggable.

Fixes zulip#23716
PIG208 added a commit to PIG208/zulip that referenced this issue Aug 10, 2023
This also removes sorting on the pattern and the URL template, because
it does not make sense anymore as we make linkifiers draggable.

Fixes zulip#23716
PIG208 added a commit to PIG208/zulip that referenced this issue Aug 10, 2023
This also removes sorting on the pattern and the URL template, because
it does not make sense anymore as we make linkifiers draggable.

Fixes zulip#23716
PIG208 added a commit to PIG208/zulip that referenced this issue Aug 10, 2023
This also removes sorting on the pattern and the URL template, because
it does not make sense anymore as we make linkifiers draggable.

Fixes zulip#23716
PIG208 added a commit to PIG208/zulip that referenced this issue Aug 10, 2023
This also removes sorting on the pattern and the URL template, because
it does not make sense anymore as we make linkifiers draggable.

Fixes zulip#23716
PIG208 added a commit to PIG208/zulip that referenced this issue Aug 10, 2023
This also removes sorting on the pattern and the URL template, because
it does not make sense anymore as we make linkifiers draggable.

Fixes zulip#23716
PIG208 added a commit to PIG208/zulip that referenced this issue Aug 10, 2023
This also removes sorting on the pattern and the URL template, because
it does not make sense anymore as we make linkifiers draggable.

Fixes zulip#23716
PIG208 added a commit to PIG208/zulip that referenced this issue Aug 10, 2023
This also removes sorting on the pattern and the URL template, because
it does not make sense anymore as we make linkifiers draggable.

Fixes zulip#23716
PIG208 added a commit to PIG208/zulip that referenced this issue Aug 11, 2023
This also removes sorting on the pattern and the URL template, because
it does not make sense anymore as we make linkifiers draggable.

Fixes zulip#23716
PIG208 added a commit to PIG208/zulip that referenced this issue Aug 11, 2023
This also removes sorting on the pattern and the URL template, because
it does not make sense anymore as we make linkifiers draggable.

Fixes zulip#23716
PIG208 added a commit to PIG208/zulip that referenced this issue Aug 11, 2023
This also removes sorting on the pattern and the URL template, because
it does not make sense anymore as we make linkifiers draggable.

Fixes zulip#23716
PIG208 added a commit to PIG208/zulip that referenced this issue Aug 11, 2023
This also removes sorting on the pattern and the URL template, because
it does not make sense anymore as we make linkifiers draggable.

Fixes zulip#23716
PIG208 added a commit to PIG208/zulip that referenced this issue Aug 11, 2023
This also removes sorting on the pattern and the URL template, because
it does not make sense anymore as we make linkifiers draggable.

Fixes zulip#23716
PIG208 added a commit to PIG208/zulip that referenced this issue Aug 11, 2023
This also removes sorting on the pattern and the URL template, because
it does not make sense anymore as we make linkifiers draggable.

Fixes zulip#23716
timabbott pushed a commit to PIG208/zulip that referenced this issue Aug 11, 2023
This also removes sorting on the pattern and the URL template, because
it does not make sense anymore as we make linkifiers draggable.

Fixes zulip#23716
PIG208 added a commit to PIG208/zulip that referenced this issue Aug 14, 2023
This also removes sorting on the pattern and the URL template, because
it does not make sense anymore as we make linkifiers draggable.

Fixes zulip#23716
timabbott pushed a commit that referenced this issue Aug 14, 2023
This also removes sorting on the pattern and the URL template, because
it does not make sense anymore as we make linkifiers draggable.

Fixes #23716
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants