Mark messages as read in is:dm and -is:dm search views #25113
Comments
|
Hello @zulip/server-search members, this issue was labeled with the "area: search" label, so you may want to check it out! |
|
@zulipbot claim |
|
Welcome to Zulip, @gravedigger0! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
|
@alya Can you please elaborate on this? Is it ever necessary?
|
alya
changed the title
It will mark messages as read when applying -is:dm filter alone or coupled with stream and topic filters. But it will not mark messages as read when there is also search term present. fixes zulip#25113.
It will mark messages as read when applying -is:dm filter alone or coupled with stream and topic filters. But it will not mark messages as read when there is also search term present. Extended Tests to ensure full coverage on filter.js fixes zulip#25113.
It will mark messages as read when applying -is:dm filter alone or coupled with stream and topic filters. But it will not mark messages as read when there is also search term present. fixes zulip#25113.
It will mark messages as read when applying -is:dm filter alone or coupled with stream and topic filters. But it will not mark messages as read when there is also search term present. Extended Tests to ensure full coverage on filter.js fixes zulip#25113.
It will mark messages as read when applying -is:dm filter alone or coupled with stream and topic filters. But it will not mark messages as read when there is also search term present. Extended Tests to ensure full coverage on filter.js fixes zulip#25113.
It will mark messages as read when applying -is:dm filter alone or coupled with stream and topic filters. But it will not mark messages as read when there is also search term present. fixes zulip#25113.
It will mark messages as read when applying -is:dm filter alone or coupled with stream and topic filters. But it will not mark messages as read when there is also search term present. Fixes zulip#25113.
It will mark messages as read when applying -is:dm filter alone or coupled with stream and topic filters. But it will not mark messages as read when there is also search term present. Fixes zulip#25113.
It will mark messages as read when applying -is:dm filter alone or coupled with stream and topic filters. But it will not mark messages as read when there is also search term present. Fixes zulip#25113.
|
@syed-rafat You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks! |
Our intended design is that search views should mark messages as read if they do not break up conversations (i.e., all the messages in the conversation are shown, or none are).
To be consistent with this pattern,
is:dmand-is:dmsearch views should mark messages as read (they currently do not).Ideally, combining
-is:dmwith a stream and/or topic filter (where-is:dmis a no-op), or similarlyis:dmwith a DM conversation filter, should also mark messages as read, but it's not worth worrying about if it's complicated from a code perspective, as it's unlikely to come up much.Of course, to be consistent with the general design, messages should not be marked as read in a search that combines
is:dmwith, e.g., a search keyword.Related comment: #12883 (comment)
The text was updated successfully, but these errors were encountered: