Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve empty message views in unsubscribed streams #29692

Open
1 of 4 tasks
alya opened this issue Apr 11, 2024 · 1 comment · May be fixed by #29706
Open
1 of 4 tasks

Improve empty message views in unsubscribed streams #29692

alya opened this issue Apr 11, 2024 · 1 comment · May be fixed by #29706
Assignees
@nimishmedatwal
Labels
area: message feed (UI) Buttons/UI directly in the message feed (not popovers, etc.) help wanted in progress

Comments

@alya
Copy link
Contributor

alya commented Apr 11, 2024 •
edited by laurynmm

We currently show a custom message when a user views a stream they are not subscribed to that has no messages in it. This is an unusual situation, and we should make it work more similarly to other contexts:

  • Show the standard empty message feed placeholder. ("There are no messages here. Why not start the conversation?")
  • Style the "Subscribe" button as it's styled in a non-empty stream.
  • Show the "Subscribe" button when viewing an empty topic in an unsubscribed stream (currently missing).
  • Show the "You are not subscribed..." bookend for empty unsubscribed stream and stream/topic views.

CZO thread
@alya alya added area: message feed (UI) Buttons/UI directly in the message feed (not popovers, etc.) help wanted labels Apr 11, 2024
@nimishmedatwal
Copy link
Collaborator

@zulipbot claim

nimishmedatwal added a commit to nimishmedatwal/zulip that referenced this issue Apr 12, 2024
@nimishmedatwal
message_feed: Improve placeholder text for empty unsubscribed stream.
45c60e7 
This commit changes the placeholder text
along with fixing the style issue of
subscribe button in empty unsubscribed
streams.

Fixes zulip#29692.
nimishmedatwal added a commit to nimishmedatwal/zulip that referenced this issue Apr 12, 2024
@nimishmedatwal
message_feed: Improve placeholder text for empty unsubscribed stream.
b51d854 
This commit changes the placeholder text
along with fixing the style issue of
subscribe button in empty unsubscribed
streams.

Fixes zulip#29692.
@nimishmedatwal nimishmedatwal linked a pull request Apr 12, 2024 that will close this issue
Open
12 tasks
nimishmedatwal added a commit to nimishmedatwal/zulip that referenced this issue Apr 12, 2024
@nimishmedatwal
message_feed: Improve placeholder text for empty unsubscribed stream.
1563ddf 
This commit changes the placeholder text
along with fixing the style issue of
subscribe button in empty unsubscribed
streams.

Fixes zulip#29692.
nimishmedatwal added a commit to nimishmedatwal/zulip that referenced this issue Apr 13, 2024
@nimishmedatwal
message_feed: Improve placeholder text for empty unsubscribed stream.
ca04439 
This commit changes the placeholder text
along with fixing the style issue of
subscribe button in empty unsubscribed
streams.

Fixes zulip#29692.
nimishmedatwal added a commit to nimishmedatwal/zulip that referenced this issue Apr 13, 2024
@nimishmedatwal
message_feed: Improve placeholder text for empty unsubscribed stream.
624b7ab 
This commit changes the placeholder text
along with fixing the style issue of
subscribe button in empty unsubscribed
streams.

Fixes zulip#29692.
nimishmedatwal added a commit to nimishmedatwal/zulip that referenced this issue Apr 13, 2024
@nimishmedatwal
message_feed: Improve placeholder text for empty unsubscribed stream.
6249d30 
This commit changes the placeholder text
along with fixing the style issue of
subscribe button in empty unsubscribed
streams.

Fixes zulip#29692.
nimishmedatwal added a commit to nimishmedatwal/zulip that referenced this issue Apr 13, 2024
@nimishmedatwal
message_feed: Improve placeholder text for empty unsubscribed stream.
a968fc2 
This commit changes the placeholder text
along with fixing the style issue of
subscribe button in empty unsubscribed
streams.

Fixes zulip#29692.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nimishmedatwal nimishmedatwal

Labels
area: message feed (UI) Buttons/UI directly in the message feed (not popovers, etc.) help wanted in progress
Projects
Zulip 9.0 priorities
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Message Feed: Improve placeholder text for empty unsubscribed stream. nimishmedatwal/zulip
3 participants
@alya @zulipbot @nimishmedatwal