-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change interaction UI for adding users when creating streams #29825
Comments
Hello @zulip/server-onboarding, @zulip/server-streams members, this issue was labeled with the "area: onboarding", "area: stream settings" labels, so you may want to check it out! |
The current plan is to sequence this after the part that's still in #29403. |
12 tasks
Asked some clarifying questions here: CZO thread |
shubham-padia
added a commit
to shubham-padia/zulip
that referenced
this issue
Jun 27, 2024
shubham-padia
added a commit
to shubham-padia/zulip
that referenced
this issue
Jun 27, 2024
shubham-padia
added a commit
to shubham-padia/zulip
that referenced
this issue
Jun 27, 2024
Fixes zulip#29825. Clicking on remove button will not delete the row anymore. We will add a strikethrough to the user pill and email text. `Remove` button will change to `Add` on click to undo this action. Re-adding a user explicitly should will not undo the soft remove on their row. e.g If `Iago` was added as part of a group and crossed out. Now, adding another group with Iago as part of it should not undo the soft remove. We maintain a seperate set of soft removed users, but we will not remove those users from the main user list on clicking `Remove`. That list can only be modified by actions with the input pills. We will subtract the soft removed user ids from main user id list when sending the request to add subscribers to the new channel.
12 tasks
shubham-padia
added a commit
to shubham-padia/zulip
that referenced
this issue
Jun 27, 2024
Clicking remove in the subscriber list table should strikethrough according to the new behaviour but we will do that in the next commit. One additional detail to the specs described in zulip#29825 is that we will not have a pill for the current user. Discussion can be found here: https://chat.zulip.org/#narrow/stream/6-frontend/topic/Disabled.2Fun-editable.20input.20pill/near/1838691
shubham-padia
added a commit
to shubham-padia/zulip
that referenced
this issue
Jun 27, 2024
Fixes zulip#29825. Clicking on remove button will not delete the row anymore. We will add a strikethrough to the user pill and email text. `Remove` button will change to `Add` on click to undo this action. Re-adding a user explicitly should will not undo the soft remove on their row. e.g If `Iago` was added as part of a group and crossed out. Now, adding another group with Iago as part of it should not undo the soft remove. We maintain a seperate set of soft removed users, but we will not remove those users from the main user list on clicking `Remove`. That list can only be modified by actions with the input pills. We will subtract the soft removed user ids from main user id list when sending the request to add subscribers to the new channel.
shubham-padia
added a commit
to shubham-padia/zulip
that referenced
this issue
Jun 27, 2024
Fixes zulip#29825. Clicking on remove button will not delete the row anymore. We will add a strikethrough to the user pill and email text. `Remove` button will change to `Add` on click to undo this action. Re-adding a user explicitly should will not undo the soft remove on their row. e.g If `Iago` was added as part of a group and crossed out. Now, adding another group with Iago as part of it should not undo the soft remove. We maintain a seperate set of soft removed users, but we will not remove those users from the main user list on clicking `Remove`. That list can only be modified by actions with the input pills. We will subtract the soft removed user ids from main user id list when sending the request to add subscribers to the new channel. I've not added extra puppetteer tests, since adding users was not part of the existing tests.
shubham-padia
added a commit
to shubham-padia/zulip
that referenced
this issue
Jun 27, 2024
Fixes zulip#29825. Clicking on remove button will not delete the row anymore. We will add a strikethrough to the user pill and email text. `Remove` button will change to `Add` on click to undo this action. Re-adding a user explicitly should will not undo the soft remove on their row. e.g If `Iago` was added as part of a group and crossed out. Now, adding another group with Iago as part of it should not undo the soft remove. We maintain a seperate set of soft removed users, but we will not remove those users from the main user list on clicking `Remove`. That list can only be modified by actions with the input pills. We will subtract the soft removed user ids from main user id list when sending the request to add subscribers to the new channel. I've not added extra puppetteer tests, since adding users was not part of the existing tests.
shubham-padia
added a commit
to shubham-padia/zulip
that referenced
this issue
Jun 27, 2024
Fixes zulip#29825. Clicking on remove button will not delete the row anymore. We will add a strikethrough to the user pill and email text. `Remove` button will change to `Add` on click to undo this action. Re-adding a user explicitly should will not undo the soft remove on their row. e.g If `Iago` was added as part of a group and crossed out. Now, adding another group with Iago as part of it should not undo the soft remove. We maintain a seperate set of soft removed users, but we will not remove those users from the main user list on clicking `Remove`. That list can only be modified by actions with the input pills. We will subtract the soft removed user ids from main user id list when sending the request to add subscribers to the new channel. I've not added extra puppetteer tests, since adding users was not part of the existing tests.
shubham-padia
added a commit
to shubham-padia/zulip
that referenced
this issue
Jun 28, 2024
Clicking remove in the subscriber list table should strikethrough according to the new behaviour but we will do that in the next commit. One additional detail to the specs described in zulip#29825 is that we will not have a pill for the current user. Discussion can be found here: https://chat.zulip.org/#narrow/stream/6-frontend/topic/Disabled.2Fun-editable.20input.20pill/near/1838691
shubham-padia
added a commit
to shubham-padia/zulip
that referenced
this issue
Jun 28, 2024
Fixes zulip#29825. Clicking on remove button will not delete the row anymore. We will add a strikethrough to the user pill and email text. `Remove` button will change to `Add` on click to undo this action. Re-adding a user explicitly should will not undo the soft remove on their row. e.g If `Iago` was added as part of a group and crossed out. Now, adding another group with Iago as part of it should not undo the soft remove. We maintain a seperate set of soft removed users, but we will not remove those users from the main user list on clicking `Remove`. That list can only be modified by actions with the input pills. We will subtract the soft removed user ids from main user id list when sending the request to add subscribers to the new channel. I've not added extra puppetteer tests, since adding users was not part of the existing tests.
timabbott
pushed a commit
that referenced
this issue
Jun 28, 2024
Clicking remove in the subscriber list table should strikethrough according to the new behaviour but we will do that in the next commit. One additional detail to the specs described in #29825 is that we will not have a pill for the current user. Discussion can be found here: https://chat.zulip.org/#narrow/stream/6-frontend/topic/Disabled.2Fun-editable.20input.20pill/near/1838691
shubhiscoding
pushed a commit
to shubhiscoding/zulip
that referenced
this issue
Jul 15, 2024
Clicking remove in the subscriber list table should strikethrough according to the new behaviour but we will do that in the next commit. One additional detail to the specs described in zulip#29825 is that we will not have a pill for the current user. Discussion can be found here: https://chat.zulip.org/#narrow/stream/6-frontend/topic/Disabled.2Fun-editable.20input.20pill/near/1838691
shubhiscoding
pushed a commit
to shubhiscoding/zulip
that referenced
this issue
Jul 15, 2024
Fixes zulip#29825. Clicking on remove button will not delete the row anymore. We will add a strikethrough to the user pill and email text. `Remove` button will change to `Add` on click to undo this action. Re-adding a user explicitly should will not undo the soft remove on their row. e.g If `Iago` was added as part of a group and crossed out. Now, adding another group with Iago as part of it should not undo the soft remove. We maintain a seperate set of soft removed users, but we will not remove those users from the main user list on clicking `Remove`. That list can only be modified by actions with the input pills. We will subtract the soft removed user ids from main user id list when sending the request to add subscribers to the new channel. I've not added extra puppetteer tests, since adding users was not part of the existing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem statement:
During onboarding or when creating a new channel, admin tries to add users to a new channel through the pills typeahead. But sometimes, they may click the create button without clicking the add button and assume that the people that they selected through the typeahead were already added. This leads to confusion in the future, when it turns out that those users weren't added.
Concepts:
Expected behaviour:
Typeahead behaviour
Iago
andAaron
is added to the input box, we will still displayIago
as an option. This behaviour will not change.Clicking on the remove button:
Iago
was added individually through a pill, and the admin clicks on remove in the subscriber list. A strikethrough will appear through the row. We will also toggle theremove
button to theAdd
button. The input pill will remain unchanged. Discussion on how to display the strike through is in a different message.Aaron
was added to the subscriber list via a group. A strikethrough will appear through the row. We will also toggle theremove
button to theAdd
button. The input pill will remain unchanged. We will strike out both pill text and email text. See Option 2.pngRemove
button has been clicked for all the users from the above group addition, we will not remove the pill.Create
button to create the channel, all the strikethrough-ed users will not be part of the user id array being sent to create the channel.Pills behaviour:
General:
Add all users
behaviour will remain unchangedCZO thread
The text was updated successfully, but these errors were encountered: