Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements: Upgrade httpretty to latest version #3400

Closed
hackerkid opened this issue Jan 20, 2017 · 12 comments
Closed

requirements: Upgrade httpretty to latest version #3400

hackerkid opened this issue Jan 20, 2017 · 12 comments

Comments

@hackerkid
Copy link
Member

Upgrading httppretty (requirements/moto.txt) directly to the latest version should break the code. So you may have to make some changes in the codebase or add some extra dependencies for upgrading.

@thesharpshooter
Copy link

Hey There!
I would like to work on this issue.I am new here, so can you guide me with it?
Thanks

@hackerkid
Copy link
Member Author

hackerkid commented Jan 22, 2017

@thesharpshooter

  • You can run pip list --outdated to get a list of all outdated packages. The command will also show the current version which Zulip is using as well the latest version of the package.
  • Now update the version of the package to the latest release in the file requirements/moto.tx.
  • To upgrade the package do provision ->./tools/provision.py
  • If the provision completes successfully go ahead and run the tests. ./tools/test-all. One of these tests should fail. Or alternatively you can push to GitHub and wait for Travis to run the tests (You have to enable Travis for your fork or create a PR). Figure out why the tests are failing and try to fix it. :)

If you need more assistance jump on to https://chat.zulip.org

@thesharpshooter
Copy link

thesharpshooter commented Jan 22, 2017

Hey! I am using Mac OS and when i tried running ./tools/provision.py it says so such file or directory as proc/meminfo

@hackerkid
Copy link
Member Author

Are you using vagrant?

@thesharpshooter
Copy link

yes

@thesharpshooter
Copy link

thesharpshooter commented Jan 23, 2017

Hey just did what you said and ran the test and it passed all of them except the front end tests
FAIL Find "View Source" within the selector ".popover_edit_message"
FAIL "#admin-realm-message-editing-status" never appeared in 5000ms

@hackerkid
Copy link
Member Author

@thesharpshooter You should make a PR. I think you should not worry about that front-end test. It must be due to some regression.

@decached
Copy link
Collaborator

Hope I've not highjacked the issue :)
I've made a pull request for this. @hackerkid

@lonerz
Copy link
Member

lonerz commented Mar 16, 2017

@decached I think you're in the clear.

@rht
Copy link
Collaborator

rht commented May 13, 2017

The httpretty dependency was gone when I tried bumping moto to the latest version (as of May 2017). This PR (bumping moto) is incoming after 2 more PR's after #4780. Afterward, this issue and #4095 can be closed.

@hackerkid
Copy link
Member Author

Fixed in d431d50

@timabbott
Copy link
Sponsor Member

Hmm, @rht, I guess we'll end up removing httpretty in your work on requirements.txt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants