Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show box for broken/unloaded images. #3564

Closed
rishig opened this issue Feb 3, 2017 · 19 comments
Closed

Show box for broken/unloaded images. #3564

rishig opened this issue Feb 3, 2017 · 19 comments

Comments

@rishig
Copy link
Member

rishig commented Feb 3, 2017

Currently, if an image doesn't load, there is just an empty white space. Some sort of indication (light grey box?) would be great.
See https://chat.zulip.org/#narrow/stream/general/topic/emoji.20display.20delay for an example.

@timabbott
Copy link
Sponsor Member

Yeah, this would be great to improve (and probably not too hard).

@rohithasrk
Copy link
Contributor

Will work on this.

@jajodiaraghav
Copy link
Collaborator

@rohithasrk Are you working on the issue or can i take this?
@timabbott Any idea about how to tackle this?

@timabbott
Copy link
Sponsor Member

@brockwhittaker may be able to provide advice on browser features that support this, but basically if an image doesn't load, we want to replace it with a fixed 100x100 "error" image.

@timabbott
Copy link
Sponsor Member

I think given that it's been a few weeks with no PR, it's reasonable to assume that @rohithasrk isn't working on this.

@jajodiaraghav
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Mar 7, 2017

Hello @jajodiaraghav, you claimed this issue to work on it, but this issue hasn't been updated for a week. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on this issue within 3 days, or else I'll automatically remove your assignment from this issue.

If you've decided to stop working on this issue, simply comment @zulipbot abandon to abandon this issue so someone else can claim it and continue from where you left off.

Thank you for your understanding and your valuable contributions to Zulip!

@lonerz
Copy link
Member

lonerz commented Mar 7, 2017

@jajodiaraghav please ignore zulipbot's warning. Do comment to keep this task as zulipbot has made an error. Sorry for the inconvenience.

@jajodiaraghav
Copy link
Collaborator

@lonerz No issues!
Working on the design of the "error-image".

@zulipbot
Copy link
Member

Hello @jajodiaraghav, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for a week. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on this issue within 3 days, or else I'll automatically remove your assignment from this issue.

If you've decided to stop working on this issue, simply comment @zulipbot abandon to abandon this issue so someone else can claim it and continue from where you left off.

Thank you for your understanding and your valuable contributions to Zulip!

@zulipbot
Copy link
Member

Hello @jajodiaraghav, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for a week. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 3 days.

If you've decided to work on something else, simply comment @zulipbot abandon so that someone else can claim it and continue from where you left off.

Thank you for your valuable contributions to Zulip!

@zulipbot
Copy link
Member

zulipbot commented Jul 31, 2017

Hello @jajodiaraghav , you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over ten days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@techac
Copy link
Collaborator

techac commented Jul 9, 2018

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Jul 9, 2018

Welcome to Zulip, @techac! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@techac
Copy link
Collaborator

techac commented Jul 10, 2018

@timabbott can you tell me which are the related files (i guess 'static/') and what resources can i refer ? Thanks...

techac added a commit to techac/zulip that referenced this issue Jul 26, 2018
techac added a commit to techac/zulip that referenced this issue Aug 1, 2018
techac added a commit to techac/zulip that referenced this issue Aug 1, 2018
techac added a commit to techac/zulip that referenced this issue Aug 1, 2018
techac added a commit to techac/zulip that referenced this issue Aug 1, 2018
techac added a commit to techac/zulip that referenced this issue Aug 1, 2018
techac added a commit to techac/zulip that referenced this issue Aug 5, 2018
techac added a commit to techac/zulip that referenced this issue Aug 5, 2018
@techac
Copy link
Collaborator

techac commented Aug 5, 2018

@zulipbot abandon

@ajitesh-30
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Hello @ajitesh-30, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

@speerwil
Copy link
Collaborator

speerwil commented Apr 5, 2019

@rishig or @timabbott when looking through this issue I am unsure if it is completed. It seems that @techac may have completed this in issue #10066.

Thanks,
Will

vrongmeal pushed a commit to vrongmeal/zulip that referenced this issue May 17, 2019
Using lazysizes we only load images if they are in view.
This decreases load time and save more bandwidth since images are loaded
after html is loaded and if they are on screen.

Fixes zulip#3564.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants