Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS for avatar upload widget #4223

Closed
timabbott opened this issue Mar 21, 2017 · 5 comments
Closed

Fix CSS for avatar upload widget #4223

timabbott opened this issue Mar 21, 2017 · 5 comments

Comments

@timabbott
Copy link
Sponsor Member

The "Uploading..." text appears in a weird place; I think probably we can just remove the text, given that we have a loading spinner anyway.

There may be a similar issue with the organization upload widget.

@zulipbot
Copy link
Member

Hello @zulip/server-misc members, this issue was labeled with the area: uploads label, so you may want to check it out!

@manjithd2
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Congratulations, @manjithd2, you've successfully claimed your first issue! Since you're a new contributor, you now have pull (read-only) access to this repository.

Please review our code contribution guidelines and sign the Dropbox Contributor License Agreement before opening any pull requests for any issues that you're working on.

Also, if you haven't done so already, please join us on the Zulip development server at chat.zulip.org! Our community of developers use chat.zulip.org as our primary communication forum for developing Zulip; you can read more about the chat.zulip.org community in our documentation.

Note: Depending on your notification settings, granting you the permission in GitHub's model that allows you to be assigned issues by zulipbot may result in making you a "watcher" on this repository, which means that you'll get notifications for every issue and pull request in this repository; for a large repository like zulip/zulip, that means receiving over 100 emails per day. If you don't want to receive notifications unless you're actually involved with the issue (which is usually the right choice for large projects), you should unwatch this repository.

@manjithd2
Copy link
Collaborator

Hi, @timabbott I am working on this. I'll clean up my commit and give a PR soon!

@timabbott
Copy link
Sponsor Member Author

@manjithd2 you should try the approach of just modifying loading.make_indicator to not pass text in this case and see how that looks.

digi0ps added a commit to digi0ps/zulip that referenced this issue Apr 5, 2017
Previously the Upload spinner was going off position.
This commit adresses that.
Fixes zulip#4223
timabbott pushed a commit that referenced this issue Apr 5, 2017
Previously the "Uploading" text was floating outside the upload
widget.

Fixes #4223.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants