Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate "Sending invitation" output spam in test_signup #7563

Closed
gnprice opened this issue Nov 29, 2017 · 3 comments
Closed

Eliminate "Sending invitation" output spam in test_signup #7563

gnprice opened this issue Nov 29, 2017 · 3 comments
Labels
area: testing-coverage

Comments

@gnprice
Copy link
Member

gnprice commented Nov 29, 2017

We're getting close to eliminating output spam in our tests! One of the remaining cases is in tools/test-backend zerver.tests.test_signup, a bunch of lines like this:

2017-11-29 01:22:45.669 INFO [] Sending invitation for realm zulip to alice@zulip.com

We should work out where those are coming from and clean them up.
@zulipbot
Copy link
Member

Hello @zulip/server-testing members, this issue was labeled with the area: testing-coverage label, so you may want to check it out!

@gnprice
Copy link
Member Author

gnprice commented Nov 29, 2017

(See #1587 for locking this kind of problem down entirely in the future.)

@gnprice gnprice mentioned this issue Nov 29, 2017
Merged
@hackerkid
Copy link
Member

@zulipbot claim

hackerkid added a commit to hackerkid/zulip that referenced this issue Nov 30, 2017
@hackerkid
tests: Mock out logging in test_successful_invite_user_with_name_and_…
8d6290e 
…normal_one.

Fixes zulip#7563
@hackerkid hackerkid mentioned this issue Nov 30, 2017
Merged
hackerkid added a commit to hackerkid/zulip that referenced this issue Dec 5, 2017
@hackerkid
tests: Eliminate "Sending invitation" output spam in test_signup.
1f47f24 
fixes zulip#7563
hackerkid added a commit to hackerkid/zulip that referenced this issue Dec 20, 2017
@hackerkid
tests: Eliminate 'Sending invitation' output spam in test_signup.
1e4a2ac 
Fixes zulip#7563
gnprice pushed a commit that referenced this issue Dec 21, 2017
@hackerkid @gnprice
tests: Eliminate 'Sending invitation' output spam in test_signup.
16d8244 
Fixes #7563
showell pushed a commit to showell/zulip that referenced this issue Dec 21, 2017
@hackerkid
tests: Eliminate 'Sending invitation' output spam in test_signup.
edf4c42 
Fixes zulip#7563
showell pushed a commit to showell/zulip that referenced this issue Dec 21, 2017
@hackerkid
tests: Eliminate 'Sending invitation' output spam in test_signup.
472cb3f 
Fixes zulip#7563
utkarsh23 pushed a commit to utkarsh23/zulip that referenced this issue Dec 22, 2017
@hackerkid @utkarsh23
tests: Eliminate 'Sending invitation' output spam in test_signup.
d74c075 
Fixes zulip#7563
showell pushed a commit to showell/zulip that referenced this issue Dec 22, 2017
@hackerkid
tests: Eliminate 'Sending invitation' output spam in test_signup.
f596b44 
Fixes zulip#7563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: testing-coverage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gnprice @hackerkid @zulipbot