Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Stream Side-Menu closes itself while typing in the search box(Mobile Web). #7896

Closed
MadElf1337 opened this issue Dec 26, 2017 · 10 comments

Comments

@MadElf1337
Copy link
Contributor

From @MadElf1337 on December 25, 2017 12:38

  • Whenever a person tries to search for a stream in the search box provided in the streams' side menu in
    mobile version of chat.zulip.org, the menu closes itself.

Instructions For Reproduction:-

  1. Go to https://chat.zulip.org from the mobile browser.
  2. Login with valid credentials.
  3. Open the side-menu of streams.
  4. Tap on the search box to enable keyboard.
  • After following these steps, one sees that the menu closes itself to go back to the home-page.
    (GIF attached below)

bug

Copied from original issue: zulip/zulip-mobile#1631

@MadElf1337
Copy link
Contributor Author

From @tommyip on December 25, 2017 16:50

Hey @MadElf1337 this repo is for the react native app. What you are showing is the webapp in a mobile browser, can you move this to the zulip/zulip repo?

@synicalsyntax
Copy link
Member

synicalsyntax commented Dec 26, 2017

I can't reproduce. Can you provide a more detailed description or point out what I didn't do in order to reach where you encountered the bug? (an actual GIF instead of 3 images strung together would be more helpful)

https://gyazo.com/40dc4b7db72a5d346ca22ce126b307ae

Note: what's shown above is the intended behavior, if you were trying to search in the search input through a different method it's likely that it's unintended user behavior, which would call for an UI/UX enhancement and not bug resolvation.

@MadElf1337
Copy link
Contributor Author

@synicalsyntax Well, it is still happening to me and also happened to Tommy Ip, as he said that he can reproduce
What browser are you using?

@synicalsyntax
Copy link
Member

@MadElf1337 Did you take the exact steps shown in the GIF? I tested through mobile view (developer tools) on Chrome & Firefox Mac OS X, and Safari iOS for actual mobile testing.

@MadElf1337
Copy link
Contributor Author

Yeah..I took them exactly like that

@MadElf1337
Copy link
Contributor Author

Well, it may not work like that on mobile view, try it on an actual android phone

@synicalsyntax
Copy link
Member

@tommyip Are you on Android? If so this may just be an Android problem.

@tommyip
Copy link
Member

tommyip commented Dec 26, 2017

@synicalsyntax it's either an Android/Chrome issue, or a performance issue. I can reproduce it semi-reliably in Android 8.1. Sometimes the sidebar just collapse instantly, or the search box appear but then the sidebar closes after a second.

@synicalsyntax
Copy link
Member

Yeah, likely an Android only issue then, since I can't reproduce on iOS/Safari. Pinging @brockwhittaker to see what's up.

@zulipbot
Copy link
Member

Hello @zulip/server-sidebars members, this issue was labeled with the area: left-sidebar label, so you may want to check it out!

@synicalsyntax synicalsyntax self-assigned this Jan 1, 2018
showell pushed a commit that referenced this issue Jan 4, 2018
This prevents the sidebars from automatically closing when users
click inside the popover area. Fixes #7896.
Kumar-Tarun pushed a commit to Kumar-Tarun/zulip that referenced this issue Jan 17, 2018
This prevents the sidebars from automatically closing when users
click inside the popover area. Fixes zulip#7896.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants