Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow admins to lock topics. #8041

Open
tommyip opened this issue Jan 9, 2018 · 9 comments · May be fixed by #8214
Open

Allow admins to lock topics. #8041

tommyip opened this issue Jan 9, 2018 · 9 comments · May be fixed by #8214
Labels
area: topics new feature A proposed new feature for the product

Comments

@tommyip
Copy link
Member

tommyip commented Jan 9, 2018

From this discussion

This feature should allow admins to lock a topic to prevent further discussion.

@graszka22
Copy link
Collaborator

@zulipbot claim

@zulipbot
Copy link
Member

Hello @zulip/server-misc members, this issue was labeled with the area: topics label, so you may want to check it out!

@graszka22
Copy link
Collaborator

I have implemented most of the functionality, but I have a question about how we should indicate that the topic is locked in the UI. My propositions are:

  • a message automatically sent to the topic like this (note that the message looks like it's sent by the admin - I think creating a bot just for this purpose is too much):

image

  • a small lock next to the topic name (perhaps it's slightly off, it's just for showing a concept :) )
    image

  • when the topic is locked and the user clicks a message to reply in this topic the compose box just doesn't appear

  • when user uses 'c' shortcut and specify a locked topic he gets the following error:
    image

@tommyip
Copy link
Member Author

tommyip commented Jan 21, 2018

I think we need multiple indications:

  • Stream list: The lock icon is used for invite-only streams already. Perhaps we could grey out the topic name and/or append a (locked) text next to it?

  • Message view

a message automatically sent to the topic like this (note that the message looks like it's sent by the admin - I think creating a bot just for this purpose is too much):

I think a message in the divider would do the job
image

  • Compose box: When the user attempt to open the compose box we should show a popup or warning (the one for UI error message). Just not appearing without any response isn't very good UX.

graszka22 added a commit to graszka22/zulip that referenced this issue Jan 29, 2018
@graszka22 graszka22 linked a pull request Jan 29, 2018 that will close this issue
graszka22 added a commit to graszka22/zulip that referenced this issue Jan 29, 2018
graszka22 added a commit to graszka22/zulip that referenced this issue Feb 6, 2018
@zulipbot
Copy link
Member

Hello @graszka22, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for 10 days. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 4 days.

If you've decided to work on something else, simply comment @zulipbot abandon so that someone else can claim it and continue from where you left off.

Thank you for your valuable contributions to Zulip!

@graszka22
Copy link
Collaborator

@zulipbot bump

graszka22 added a commit to graszka22/zulip that referenced this issue Mar 1, 2018
graszka22 added a commit to graszka22/zulip that referenced this issue Mar 11, 2018
graszka22 added a commit to graszka22/zulip that referenced this issue Mar 20, 2018
graszka22 added a commit to graszka22/zulip that referenced this issue Mar 21, 2018
@zulipbot
Copy link
Member

zulipbot commented Apr 9, 2018

Hello @graszka22, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@Gittenburg Gittenburg added new feature A proposed new feature for the product and removed enhancement labels Jul 9, 2020
@vanclute
Copy link

As a community admin/mod, I would very much like the ability to lock topics. I would also love to be able to selectively assign the power to lock/unlock to moderator roles. Don't always want all mods to have it, but the more senior/trusted ones, yes.

@andreasoc
Copy link

i agree with this features!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: topics new feature A proposed new feature for the product
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants