Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

message view: Success/error message for changing the topic from the recipient bar needs updating. #8793

Closed
rishig opened this issue Mar 22, 2018 · 2 comments

Comments

@rishig
Copy link
Member

rishig commented Mar 22, 2018

If you change the topic from the recipient bar (you need to be an admin to do this), it'll give you a success message that sort of looks like this, but in green:
image

Instead of having a success message, we should just have the checkbox turn into a spinner when you click it, and the X disappear.
Not sure what to do if the backend returns an error, but we can handle that as followup.

@zulipbot
Copy link
Member

Hello @zulip/server-message-view members, this issue was labeled with the "area: message view" label, so you may want to check it out!

@AasthaGupta
Copy link
Collaborator

@zulipbot claim

AasthaGupta added a commit to AasthaGupta/zulip that referenced this issue Mar 23, 2018
On clicking the checkbox in topic edit form, display a
spinner and hide the cancel icon.
Also, do not display any success message.

Fixes zulip#8793
AasthaGupta added a commit to AasthaGupta/zulip that referenced this issue Mar 23, 2018
On clicking the checkbox in topic edit form, display a
spinner and hide the cancel icon.
Also, do not display any success message.

Fixes zulip#8793
AasthaGupta added a commit to AasthaGupta/zulip that referenced this issue Mar 23, 2018
On clicking the checkbox in topic edit form, display a
spinner and hide the cancel icon.
Also, do not display any success message.

Fixes zulip#8793
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants