Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotkeys: Change stream settings shortcuts. #9614

Open
rishig opened this issue May 31, 2018 · 8 comments · May be fixed by #13379
Open

hotkeys: Change stream settings shortcuts. #9614

rishig opened this issue May 31, 2018 · 8 comments · May be fixed by #13379
Labels
area: keyboard UI area: stream settings help wanted

Comments

@rishig
Copy link
Member

rishig commented May 31, 2018

There are two stream settings shortcuts: n (create stream) and s (toggle subscription). These are pretty confusing, since they are some of our most common non-stream settings shortcuts. Also, "create stream" should work from anywhere, not just the stream settings modal, since people may expect it to, and be confused when it doesn't.

Let's

  • Change n to Ctr+Shift+s.
  • Make that shortcut work from the main message feed as well; i.e. not just the stream settings modal
  • Change s to t for toggle. (t will also be easier to reuse in the future, if there are other things in other modals that can be toggled.)
@Anupam-dagar
Copy link
Collaborator

@zulipbot claim

Anupam-dagar added a commit to Anupam-dagar/zulip that referenced this issue Jun 2, 2018
@Anupam-dagar
hotkeys: Change stream settings shortcuts.
be3a3c0 
hotkey 'n' is changed to 'ctrl + shift + s' and hotkey 'S' for stream subscription is changed to 'T'.
Fixes: zulip#9614
@Anupam-dagar Anupam-dagar mentioned this issue Jun 2, 2018
Closed
@rishig
Copy link
Member Author

rishig commented Jun 3, 2018

I just realized that maybe we'll want to reserve Ctrl+Shift+s for "go to starred messages", if we're going to use Ctrl+s for "star a message".

In any case though, most of the work for this making the shortcut work at all, and then we can change it afterwards.

Anupam-dagar added a commit to Anupam-dagar/zulip that referenced this issue Jun 3, 2018
@Anupam-dagar
hotkeys: Change stream settings shortcuts.
1e137cf 
hotkey 'n' is changed to 'ctrl + shift + s' and hotkey 'S' for stream subscription is changed to 'T'.
Fixes: zulip#9614
Anupam-dagar added a commit to Anupam-dagar/zulip that referenced this issue Jun 6, 2018
@Anupam-dagar
hotkey: Add "Ctrl+Shift+s" and change "S" to "T" hotkey.
09bb038 
Fixes: zulip#9684 and zulip#9614
@zulipbot
Copy link
Member

zulipbot commented Jun 13, 2018 •
edited

Hello @Anupam-dagar, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@victorphoenix3
Copy link
Collaborator

@zulipbot claim

@victorphoenix3 victorphoenix3 mentioned this issue Sep 24, 2019
Closed
@victorphoenix3
Copy link
Collaborator

@rishig My PR #13217 is ready for review.

@rishig
Copy link
Member Author

rishig commented Sep 26, 2019

awesome, thanks! Tim will review.

@victorphoenix3
Copy link
Collaborator

@zulipbot abandon

victorphoenix3 added a commit to victorphoenix3/zulip that referenced this issue Nov 6, 2019
@victorphoenix3
hotkeys: Change hotkey for creating streams.
003c80e 
fixes part of zulip#9614.
The keyboard shortcut for creating streams has been changed
from 'n' to 'ctrl+shift+s'.Also,earlier the shortcut could
only be triggered from the stream settings modal.But now
streams can be created using the hotkey without havng to
go to the stream settings modal.
victorphoenix3 added a commit to victorphoenix3/zulip that referenced this issue Nov 6, 2019
@victorphoenix3
hotkeys: Change hotkey for toggling stream subscription.
b6be388 
fixes part of zulip#9614.
changes hotkey for toggling the subscription of a stream from
'S' to 'T'.
victorphoenix3 added a commit to victorphoenix3/zulip that referenced this issue Nov 6, 2019
@victorphoenix3
hotkeys: Change hotkey for creating streams.
00e151e 
fixes part of zulip#9614.
The keyboard shortcut for creating streams has been changed
from 'n' to 'ctrl+shift+s'.Also,earlier the shortcut could
only be triggered from the stream settings modal.But now
streams can be created using the hotkey without havng to
go to the stream settings modal.
victorphoenix3 added a commit to victorphoenix3/zulip that referenced this issue Nov 6, 2019
@victorphoenix3
hotkeys: Change hotkey for toggling stream subscription.
12f6739 
fixes part of zulip#9614.
changes hotkey for toggling the subscription of a stream from
'S' to 'T'.
victorphoenix3 added a commit to victorphoenix3/zulip that referenced this issue Nov 6, 2019
@victorphoenix3
hotkeys: Change hotkey for creating streams.
e25b5b4 
fixes part of zulip#9614.
The keyboard shortcut for creating streams has been changed
from 'n' to 'ctrl+shift+s'.Also,earlier the shortcut could
only be triggered from the stream settings modal.But now
streams can be created using the hotkey without havng to
go to the stream settings modal.
victorphoenix3 added a commit to victorphoenix3/zulip that referenced this issue Nov 6, 2019
@victorphoenix3
hotkeys: Change hotkey for toggling stream subscription.
1e8709d 
fixes part of zulip#9614.
changes hotkey for toggling the subscription of a stream from
'S' to 'T'.
@victorphoenix3 victorphoenix3 linked a pull request Nov 6, 2019 that will close this issue
Open
victorphoenix3 added a commit to victorphoenix3/zulip that referenced this issue Nov 23, 2019
@victorphoenix3
hotkeys: Change hotkey for creating streams.
2d7d3ee 
fixes part of zulip#9614.
The keyboard shortcut for creating streams has been changed
from 'n' to 'ctrl+shift+s'.Also,earlier the shortcut could
only be triggered from the stream settings modal.But now
streams can be created using the hotkey without havng to
go to the stream settings modal.
victorphoenix3 added a commit to victorphoenix3/zulip that referenced this issue Nov 24, 2019
@victorphoenix3
Hotkeys: change toggle subscription hotkey from "S" to "T".
23c5854 
The hotkey for toggling subscription of a stream when in the
streams subscriptions overlay has been changed from "shift + s"
to "shift + t"
Fixes part of zulip#9614 .
victorphoenix3 added a commit to victorphoenix3/zulip that referenced this issue Nov 24, 2019
@victorphoenix3
Hotkeys: change toggle subscription hotkey from "S" to "T".
d920707 
The hotkey for toggling subscription of a stream when in the
streams subscriptions overlay has been changed from "shift + s"
to "shift + t"
Fixes part of zulip#9614 .
@zulipbot
Copy link
Member

zulipbot commented Oct 3, 2023

Hello @zulip/server-streams members, this issue was labeled with the "area: stream settings" label, so you may want to check it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: keyboard UI area: stream settings help wanted
Projects
None yet
Milestone
No milestone
5 participants
@rishig @timabbott @Anupam-dagar @zulipbot @victorphoenix3