search: Add #searchbox_legacy selector to #searchbox rules in media.s… #10043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…css. This is a fixup for e1291cf. While copying the the rules of `#searchbox` to `#searchbox_legacy` in the search pills feature, the existing `#searchbox` rules were missed in the conversion. `#searchbox_legacy` has been added beside `#searchbox` in `media.scss` instead of replacing that as both of them need those rules for the mobile view.
shubham-padia
force-pushed
the
search_media
branch
from
6649c2f
to
d140304
Compare
|
Nice, merged, thanks @shubham-padia! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…css.
This is a fixup for e1291cf.
While copying the the rules of
#searchboxto#searchbox_legacyin the search pills feature, the existing
#searchboxrules weremissed in the conversion.
#searchbox_legacyhas been added beside#searchboxinmedia.scssinstead of replacing that as both of them need those rules for the
mobile view.
Testing Plan:
GIFs or Screenshots: