typeahead: Replace no-break space (U+00A0) in query with `space (U+…
#10058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0020)`. Fixes zulip#10039. Typing "tim " did not did not produce any match when suggesting person in composebox typeahead or user group typeahead as the space at the end of the "tim " string passed by the browser was a `no break-space (U+00A0)` instead of `space (U+0020)`. Although there are unicode characters other than `no break-space` which represent spaces, only U+00A0 is replaced as it was the only space character encountered when testing this issue manually.
|
Hello @zulip/server-compose members, this pull request was labeled with the "area: compose" label, so you may want to check it out! |
|
Nice debugging! Merged, after modifying the comment to mention contenteditable inputs, since I think that's what causes the browser to produce this. Thanks @shubham-padia! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…0020)`.
Fixes #10039.
Typing "tim " did not did not produce any match when suggesting person
in composebox typeahead or user group typeahead as the space at the
end of the "tim " string passed by the browser was a
no break-space (U+00A0)instead ofspace (U+0020).Although there are unicode characters other than
no break-spacewhichrepresent spaces, only U+00A0 is replaced as it was the only space
character encountered when testing this issue manually.
One of the follow up issue after this would be to use
composebox_typeahead.query_matches_personin user group settings typeahead after extractingquery_matches_*functions to somewhere appropriate (I'm not sure about what location is appropriate atm, would put some more thought into it.).