pills: Add flex-wrap: wrap to pill container for all pills.
#10060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes zulip#10059. In 66df4e3, `display: inline-flex` was added to `.pill-container` but `flex-wrap: wrap` was missing which forced overflow pills to be on one line and made the pill text overflow vertically. This was not observed in composebox pills as `.pm_recipient .pill-container` already had a `flex-wrap: wrap` rule which has been removed in this commit to avoid duplication.
shubham-padia
force-pushed
the
user_group_pill_overflow
branch
from
2c32cf3
to
f057446
Compare
|
Nice. Might be worth a quick check for whether any of the other CSS in the pm-recipient |
|
@timabbott I don't think any of the other CSS in the pm-recipient .pill_container block belongs in the generic one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10059.
In 66df4e3,
display: inline-flexwas added to.pill-containerbutflex-wrap: wrapwas missing which forced overflow pills to be onone line and made the pill text overflow vertically. This was not
observed in composebox pills as
.pm_recipient .pill-containeralready had a
flex-wrap: wraprule which has been removed in thiscommit to avoid duplication.
Before:
After:
