search-pills: Fix visual bugs due to CSS refactoring of input pills. #10081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed search pill padding, `.navbar-search` flex-wrap to match with the CSS refactoring in 66df4e3. The `height: 100%` changes to `.navbar-search` and `.input-append` make up for the issue in which the pills overflowed in the mobile view due to `.navbar-search` height being declared 40px explicitly while the actual heiight in mobile view was shorter.
|
Nice, merged, thanks @shubham-padia! One random sidenote while looking at this: We'll probably want to do some prettier things with the pills (e.g. make a stream pill use some nicer styling using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed search pill padding,
.navbar-searchflex-wrap to match withthe CSS refactoring in 66df4e3.
The
height: 100%changes to.navbar-searchand.input-appendmake up for the issue in which the pills overflowed in the mobile
view due to
.navbar-searchheight being declared 40px explicitlywhile the actual height in mobile view was shorter.
For mobile view:
Before:
After: