forms: Fix accounts listed in password_reset email to active accounts.

[shubhamdhama]

Previously we were listing both accounts, active as well as non-active.
Fixes: #10130.

A better alternative for "Kindly, contact the organization administrators." required.

[zulipbot]

Hello @zulip/server-development members, this pull request was labeled with the "area: emails" label, so you may want to check it out!

[timabbott]

Merged as 2dec30e, after:
(1) Removing the changes to the text; I wasn't sure what should go there. @rishig thoughts? The question is basically whether to mention something about deactivated accounts. I feel like it's kinda clear from how consistently we use the term "active account" in the email.
(2) Bumping PROVISION_VERSION, which one generally needs to do after changing email source templates.

Thinking about this more, though, I'd really like to have a test for this corner case. @shubhamdhama would you be up for extending the existing password reset test class to cover this case?

[shubhamdhama]

Bumping PROVISION_VERSION, which one generally needs to do after changing email source templates.

ok... I'll take care of this next time.

@shubhamdhama would you be up for extending the existing password reset test class to cover this case?

Sure, I'll do it.

[rishig]

I think something like the following?
"Someone (possibly you) requested a password reset for prospero@zulip.com on http://localhost:9991, but your account has been deactivated. You can contact an organization administrator to reactivate your account."

[reactivate your account] can be a link to https://zulipchat.com/help/deactivate-or-reactivate-a-user#reactivate-a-user? (Or possibly we should have a separate reactivate-your-account article if we're going to link to it like this; I can take care of that edit if we decide to do it.)

Also as a note remember to change both the .html.source and the .txt email when changing the email templates.

[timabbott]

Seems reasonable to me. @rishig do you want to do the PR for this?

[rishig]

This will take some refactoring, but I think it's worth it. @shubhamdhama, would you be up for making the changes, and I can review?

The final state of password_reset.source.html should be the following (note that I renamed some variables for clarity). This will probably be a string of ~10 small commits to get here.

Not sure if this is the best place to store this, or if I should open a new issue with the updated text below.

{% extends "zerver/emails/compiled/email_base_default.html" %}

{% block content %}
{% if active_account_in_realm %}
    <p>
        Psst. Word on the street is that you need a new password, {{ email }}.<br />
        It's all good. Click here and we'll take care of the rest:<br />
        <a class="button" href="{{ reset_url }}">Reset password</a>
    </p>
{% else %}
    <p>
        {% if user_deactivated %}
            Someone (possibly you) requested a password reset email for {{ email }}
            on {{ realm_uri }}, but your account has been deactivated. You can contact
            an organization administrator to reactivate your account.
        {% else %}
            Someone (possibly you) requested a password reset email for {{ email }}
            on {{ realm_uri }}, but you do not have an account in that organization.
        {% endif %}
    </p>
    {% if active_accounts_in_other_realms %}
        <p>
            You do have active accounts in the following organization(s).
            <ul>
                {% for active_account in active_accounts_in_other_realms %}
                <li>{{ active_accounts.realm.uri }}</li>
                {% endfor %}
            </ul>
            You can try logging in or resetting your password in the organization(s)
            above.
        </p>
    {% endif %}
{% endif %}
<p>
    Thanks,<br />
    Your friends at Zulip HQ
</p>
{% endblock %}