Tab opens empty typeahead #10240
Tab opens empty typeahead #10240
Conversation
Fixes part of zulip#10026. NOTE: The Tab key will select option from typeahead if the typeahead is already open i.e the same behaviour as Enter. NOTE: This behaviour applies irrespective of search pills are enabled or not.
Fixes part of zulip#10026. Adds additional option to typeahead: `tabOpensEmptyTypeahead`(default: false): tabOpensEmptyTypeahead overrides helpOnEmptyStrings. This commit sets helpOnEmptyStrings to false and tabOpensEmptyTypeahead to true. Now typeahead will open on an empty string only if Tab has been pressed.
|
So, the following behaves oddly for me with these changes:
|
|
@timabbott I'm unable to repro this. I may have misunderstood your comment, attaching below gif for reference (the keystrokes are not being shown on the screen, I'm just trying to confirm whether you did something similar) |
|
OK, I tested as well, and this seems to work correctly. Merged, thanks @shubham-padia! |
|
I had to revert these commits, because they broke tabbing/shift-tabbing between the compose box recipient area for PMs and the main compose box. |
|
Heads up @shubham-padia, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
timabbott
force-pushed
the
main
branch
2 times, most recently
from
4ec3636
to
88b200c
Compare
Commit 1:
typeahead: Tab opens typeahead if not open with a non-empty input.
Fixes part of #10026.
NOTE: The Tab key will select option from typeahead if the typeahead
is already open i.e the same behaviour as Enter.
NOTE: This behaviour applies irrespective of search pills are enabled
or not.
Commit 2:
search: Open typeahead on empty string only if lookup triggered by Tab. …
Fixes part of #10026.
Adds additional option to typeahead:
tabOpensEmptyTypeahead(default: false):tabOpensEmptyTypeahead overrides helpOnEmptyStrings.
This commit sets helpOnEmptyStrings to false and
tabOpensEmptyTypeahead to true. Now typeahead will
open on an empty string only if Tab has been pressed.