New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webhooks/bitbucket3: Add bitbucket3 integration. #11975
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hypro999: Thanks for working on this, this looks good! I left some initial comments I'd like you to address! Also, the commit message should be webhooks: Add BitBucket Server integration.
. Feel free to reach out if you have any questions! Cheers! :)
Thanks for the review @eeshangarg! I made the changes you requested, could you give it another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hypro999: Just left a few more comments. Also, the first sentence of your commit description is not needed as it simply reiterates what the main commit message says. Let me know if you'd like to discuss something! Thanks! :)
This commit adds support for all "repo" events.
I made the requested changes @eeshangarg, any other recommendations? 🙂 |
Merged, thanks @Hypro999! :) |
This integration is for Bitbucket Server.
This commit adds support for all "repo" events.
The follow-up will add support for all "pr" events.