Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhooks/bitbucket3: Add bitbucket3 integration. #11975

Merged
merged 1 commit into from Mar 25, 2019
Merged

webhooks/bitbucket3: Add bitbucket3 integration. #11975

merged 1 commit into from Mar 25, 2019

Conversation

Hypro999
Copy link
Member

This integration is for Bitbucket Server.
This commit adds support for all "repo" events.
The follow-up will add support for all "pr" events.

Copy link
Member

@eeshangarg eeshangarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hypro999: Thanks for working on this, this looks good! I left some initial comments I'd like you to address! Also, the commit message should be webhooks: Add BitBucket Server integration.. Feel free to reach out if you have any questions! Cheers! :)

zerver/lib/integrations.py Outdated Show resolved Hide resolved
zerver/webhooks/bitbucket3/doc.md Show resolved Hide resolved
zerver/lib/integrations.py Show resolved Hide resolved
zerver/webhooks/bitbucket3/view.py Outdated Show resolved Hide resolved
zerver/webhooks/bitbucket3/view.py Outdated Show resolved Hide resolved
@Hypro999
Copy link
Member Author

Thanks for the review @eeshangarg! I made the changes you requested, could you give it another look?

Copy link
Member

@eeshangarg eeshangarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hypro999: Just left a few more comments. Also, the first sentence of your commit description is not needed as it simply reiterates what the main commit message says. Let me know if you'd like to discuss something! Thanks! :)

zerver/webhooks/bitbucket3/doc.md Outdated Show resolved Hide resolved
zerver/webhooks/bitbucket3/doc.md Outdated Show resolved Hide resolved
zerver/webhooks/bitbucket3/view.py Outdated Show resolved Hide resolved
zerver/webhooks/bitbucket3/view.py Outdated Show resolved Hide resolved
zerver/webhooks/bitbucket3/view.py Outdated Show resolved Hide resolved
zerver/webhooks/bitbucket3/view.py Show resolved Hide resolved
zerver/webhooks/bitbucket3/view.py Outdated Show resolved Hide resolved
This commit adds support for all "repo" events.
@Hypro999
Copy link
Member Author

I made the requested changes @eeshangarg, any other recommendations? 🙂

@eeshangarg eeshangarg merged commit 9ed1dcc into zulip:master Mar 25, 2019
@eeshangarg
Copy link
Member

Merged, thanks @Hypro999! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants