-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unread list: Allow toggling of streams view (2nd approach) #11994
Conversation
f5bfc57
to
e843623
Compare
e843623
to
4b5496a
Compare
This is exciting! I merged I think all of the early prep commits. A few notes:
Didn't look much at the code for the rest due to merge conflicts from #11977. |
I just merged the "remove more conversations" commit as well, thanks @showell. |
4b5496a
to
2456fa2
Compare
The first commit here is the main one to test-deploy. |
OK, doing a test deploy of just that one. |
If you click on the icon to the left of "ALL STREAMS", you now get a view that shows only unread topics (plus the currently narrowed stream/topic, if relevant).
A lot of users would like this to be the case now, but we have held off on it due to some users wanting more real estate for streams. Hopefully, once we add filters for showing only unread messages, this will be tolerable for all users.
2456fa2
to
e71ba24
Compare
@showell just to check, should I include the WIP commits in the next test-deploy? |
Heads up @showell, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
The czo deploy of this is broken as of #12370; it throws |
This is way too bit-rotted to resurrect. Also, I think "Recent Topics" is a better solution. Closing. |
This is a somewhat more moderate approach to emulating the mobile unreads view on the main webapp while still playing nice with the old layout.
The first four commits, particularly the first one, should be ready to merge to master, regardless of where we go with the unreads view.
The fifth commit could also be merged, although it's mostly orthogonal to this effort, and we are still having conversation about making our search vs. filter terminology consistent.
The sixth commit is ready to test deploy, and it turns on unread-filtering for streams only.
The last couple commits are related to PMs, and I'm fine either way on test-deploying them. (There's still more work to do there, but the commits are coherent.)
Before test deploying, please ping me so we can communicate what's been done on this branch to czo users.