Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unread list: Allow toggling of streams view (2nd approach) #11994

Closed
wants to merge 4 commits into from

Conversation

showell
Copy link
Contributor

@showell showell commented Mar 26, 2019

This is a somewhat more moderate approach to emulating the mobile unreads view on the main webapp while still playing nice with the old layout.

The first four commits, particularly the first one, should be ready to merge to master, regardless of where we go with the unreads view.

The fifth commit could also be merged, although it's mostly orthogonal to this effort, and we are still having conversation about making our search vs. filter terminology consistent.

The sixth commit is ready to test deploy, and it turns on unread-filtering for streams only.

The last couple commits are related to PMs, and I'm fine either way on test-deploying them. (There's still more work to do there, but the commits are coherent.)

Before test deploying, please ping me so we can communicate what's been done on this branch to czo users.

@timabbott
Copy link
Sponsor Member

timabbott commented Apr 11, 2019

This is exciting! I merged I think all of the early prep commits. A few notes:

  • I'm going to test-deploy just the "remove more conversations" commit on czo to get some experience with it. My read is that we should likely merge it once we're sure it'd bug-free, since even if we added back a "more conversations" like concept, we'd probably want that to be a totally different thing that fetches more messages from the server. I also wanted to flag mobile: Add support for recent_conversations API. #11946 -- I think it'd be really valuable to integrate the data from that PR (which basically does what "more conversations" should have done), which would provide a 10x-50x better scrollback data set.

Didn't look much at the code for the rest due to merge conflicts from #11977.

@timabbott
Copy link
Sponsor Member

I just merged the "remove more conversations" commit as well, thanks @showell.

@showell
Copy link
Contributor Author

showell commented Apr 12, 2019

The first commit here is the main one to test-deploy.

@timabbott
Copy link
Sponsor Member

OK, doing a test deploy of just that one.

Steve Howell added 4 commits April 18, 2019 02:00
If you click on the icon to the left of "ALL STREAMS",
you now get a view that shows only unread topics (plus
the currently narrowed stream/topic, if relevant).
A lot of users would like this to be the case now,
but we have held off on it due to some users wanting
more real estate for streams.

Hopefully, once we add filters for showing only
unread messages, this will be tolerable for all
users.
@timabbott
Copy link
Sponsor Member

@showell just to check, should I include the WIP commits in the next test-deploy?

@zulipbot
Copy link
Member

Heads up @showell, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

@andersk
Copy link
Member

andersk commented Jun 19, 2019

The czo deploy of this is broken as of #12370; it throws TypeError: stream_data.in_home_view is not a function at left_sidebar.js:18.

@showell
Copy link
Contributor Author

showell commented Jul 10, 2020

This is way too bit-rotted to resurrect. Also, I think "Recent Topics" is a better solution. Closing.

@showell showell closed this Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants