navbar: Fix stream + topic jump at 500px. #12336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YashRE42
force-pushed
the
stream_name_patch
branch
from
9af64bc
to
2553c59
Compare
|
The vertical centering of e.g. |
|
Right, I'll update this when I figure out a good way to fix that. |
|
In general, we should always having things look non-broken, and that level of vertical misalignment definitely looks broken :) |
This resolves a bug where the "stream" tab item would be missaligned with the rest of navbar and leave some empty space.
YashRE42
force-pushed
the
stream_name_patch
branch
from
2553c59
to
b87c77f
Compare
|
@timabbott I'd expect this to affect other places but seems to be okay from my manual testing: |
|
I think it's OK because the CSS block just outside that one has a height of 50px already. Thanks @YashRE42! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug on the mobile web app caused by the refactor for navbar css.
GIFs or Screenshots:
before:
after:
