night-mode: Fix invite_user_form overlap bug. #12530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the element for the invite link would cause the modal footer to shift upwards, in nightmode this caused the stream list to appear beneath the footer as the footer background was transparent. This commit replaces that styling with a solid equivalent color.
YashRE42
force-pushed
the
invite-user-nightmode-css-fix
branch
from
4fc3d71
to
9c00e9b
Compare
|
@timabbott This was a small bug fix that you might have missed. This is slightly hacky because it makes the modal footer completely opaque. |
|
Nice, merged, thanks @YashRE42! I had indeed lost track of this. |
|
I realized I may have misread this; do you think we should try to figure out a less hacky solution? |
|
I don't think it matters because it works fine and the transparent property didn't serve any use there. in fact it avoids bugs like this: that said if we want to change we could change it so the scroll is only on the stream list and not the whole modal. And adjust to account for the bump when the link is generated.... but it would probably take a lot of time for a low priority thing. |
|
OK let's declare victory here :)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the element for the invite link would cause the modal footer to
shift upwards, in nightmode this caused the stream list to appear
beneath the footer as the footer background was transparent. This commit
replaces that styling with a solid equivalent color.
Follow up to #11471.
GIFs or Screenshots:
side note: (the hsl replacement gives
#1a232einstead of#1a242f)