webhooks/bitbucket3: Add the diagnostics:ping event.
#12584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eeshangarg, requesting review 🙂 |
eeshangarg
suggested changes
Jun 15, 2019
There was a problem hiding this comment.
@Hypro999: Just left a minor comment! Apart from that, this looks great! :)
Note: Unlike with the other events supported by this webhook so far, to determine this event's event type, we need to use the X-Event-Key HTTP Header.
|
Looks great, merged, thanks @Hypro999 and @eeshangarg! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Unlike with the other events supported by this webhook so far,
to determine this event's event type, we need to use the X-Event-Key
HTTP Header.
As a follow up, we''ll most likely want to determine the event type only
from the HTTP Headers for all endpoints. It would be a good idea to do
this after merging pull request #12515.