provision: Improve error messaging when attempting to use Ubuntu Trusty. #12688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersk
reviewed
Jul 1, 2019
tools/lib/provision.py
Outdated
| try: | ||
| # This is a bit of a hack to check for Vagrant, as it's possible (although uncommon) to | ||
| # connect to a Vagrant box as a different user. | ||
| if subprocess.check_call(["grep", "-q", "^vagrant:", "/etc/passwd", ]) == 0: |
There was a problem hiding this comment.
This throws an exception if there’s no match. You meant subprocess.call. But how about os.path.exists('/home/vagrant') instead?
whoodes
force-pushed
the
improve-trusty-provision-error-messaging
branch
2 times, most recently
from
9eb333e
to
3414c50
Compare
As part of dropping support, we add appropriate error messaging when a user attempts to provision while using trusty. If the user is running in Vagrant we append information on how to proceed.
whoodes
force-pushed
the
improve-trusty-provision-error-messaging
branch
from
3414c50
to
17c3286
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of dropping support, we add appropriate error messaging when a
user attempts to provision while using trusty. If the user is running
in Vagrant we append information on how to proceed.
Testing Plan:
With
bionicin place oftrusty.Sample output: