Migrate Integrations to Storing Custom HTTP Headers by defining "fixtures_to_headers" methods.

[Hypro999]

This PR is basically an application of the work done in PR #12622 (In particular this PR addresses the request/suggestion made by @timabbott at the end of the discussion).

Here, for any integrations depending on custom http headers (which is usually just an event key) we add a fixtures_to_headers method which will determine the correct set of headers for a given fixture based on the fixture's name.

[Hypro999]

@eeshangarg, could you please review this?

[timabbott]

I merged the simple ones. For gogs, we should just rename the files; that'd be cleaner.

For GitLab, what do you think about just using a modified version of the usual method?

We could rename e.g. push_multiple_committers.json to push_hook__multiple-commiters.json, and then have this:

def fixture_to_headers(fixture_name: str) -> Dict[str, Any]
    return fixture_name.split("__")[0].replace("_", " ").title()

[Hypro999]

@timabbott, I made the change for Gogs (in retrospect, the GitHub way was the best approach for this one). I'm pretty hesitant about the suggestion for GitLab as a we'd mess up a lot of filenames in the process (making them really awkward).
E.g. confidential_issue_closed.json -> issue_hook__confidential_closed.json.
If you're sure that we should take such an approach then I'll do it.

[timabbott]

Hmm. I think issue_hook__confidential_issue_closed.json might be a better name for that one; we don't have to avoid redundancy if it makes the names more readable.

I'm not super worried about the filenames being long, especially in cases like this where it as adding clarity; text characters are cheap. :)

[timabbott]

Merged the gogs commit.

[Hypro999]

Hmm. I think issue_hook__confidential_issue_closed.json might be a better name for that one; we don't have to avoid redundancy if it makes the names more readable.
I'm not super worried about the filenames being long, especially in cases like this where it as adding clarity; text characters are cheap. :)

Cool! @timabbott, I've fixed the GitLab integration and now it follows a similar approach to the one used for the GitHub integration.

[timabbott]

Merged as fecf6a5, after adding a comment explaining the algorithm in the GitLab view.py function.

Huge thanks for fixing this @Hypro999!

Are there any remaining fixtures that don't work with the development panel, or can we declare complete victory for that project?

[Hypro999]

@timabbott this PR migrated over every single integration that had custom headers and it did so without facing any issues. So I guess that we can declare as a "complete victory" for that project 😅. Worst case I made a typo somewhere and we'll need to fix that, but otherwise structurally everything worked out.

Thanks for reviewing and for your suggestions!

[timabbott]

Just to confirm, did you test using the send all fixtures feature with each integration?

…

-Tim Abbott (mobile)

On Mon, Jul 22, 2019, 12:58 PM Hemanth V. Alluri ***@***.***> wrote: @timabbott <https://github.com/timabbott> this PR migrated over every single integration that had custom headers and it did so without facing any issues. So I guess that we can declare as a "complete victory" for that project 😅. Worst case I made a typo somewhere and we'll need to fix that, but otherwise structurally everything worked out. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#12718?email_source=notifications&email_token=AAU6NWVDEECSOZJMQHGSCL3QAYGMRA5CNFSM4H6HW542YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2Q7PQI#issuecomment-513931201>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAU6NWW5TC3FXYOX5NUXJWTQAYGMRANCNFSM4H6HW54Q> .

[Hypro999]

Everything apart from the bitbucket3 change was perfect. There was a small changed needed for bitbucket3 which I've made in #12873.