-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Integrations to Storing Custom HTTP Headers by defining "fixtures_to_headers" methods. #12718
Conversation
@eeshangarg, could you please review this? |
I merged the simple ones. For gogs, we should just rename the files; that'd be cleaner. For GitLab, what do you think about just using a modified version of the usual method? We could rename e.g.
|
@timabbott, I made the change for Gogs (in retrospect, the GitHub way was the best approach for this one). I'm pretty hesitant about the suggestion for GitLab as a we'd mess up a lot of filenames in the process (making them really awkward). |
Hmm. I think I'm not super worried about the filenames being long, especially in cases like this where it as adding clarity; text characters are cheap. :) |
Merged the gogs commit. |
We use the same approach as was used for the GitHub integration.
Cool! @timabbott, I've fixed the GitLab integration and now it follows a similar approach to the one used for the GitHub integration. |
@timabbott this PR migrated over every single integration that had custom headers and it did so without facing any issues. So I guess that we can declare as a "complete victory" for that project 😅. Worst case I made a typo somewhere and we'll need to fix that, but otherwise structurally everything worked out. Thanks for reviewing and for your suggestions! |
Just to confirm, did you test using the send all fixtures feature with each
integration?
…-Tim Abbott (mobile)
On Mon, Jul 22, 2019, 12:58 PM Hemanth V. Alluri ***@***.***> wrote:
@timabbott <https://github.com/timabbott> this PR migrated over every
single integration that had custom headers and it did so without facing any
issues. So I guess that we can declare as a "complete victory" for that
project 😅. Worst case I made a typo somewhere and we'll need to fix
that, but otherwise structurally everything worked out.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12718?email_source=notifications&email_token=AAU6NWVDEECSOZJMQHGSCL3QAYGMRA5CNFSM4H6HW542YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2Q7PQI#issuecomment-513931201>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAU6NWW5TC3FXYOX5NUXJWTQAYGMRANCNFSM4H6HW54Q>
.
|
Everything apart from the bitbucket3 change was perfect. There was a small changed needed for bitbucket3 which I've made in #12873. |
This PR is basically an application of the work done in PR #12622 (In particular this PR addresses the request/suggestion made by @timabbott at the end of the discussion).
Here, for any integrations depending on custom http headers (which is usually just an event key) we add a
fixtures_to_headers
method which will determine the correct set of headers for a given fixture based on the fixture's name.