Fix integrations sidebar #13011
Fix integrations sidebar #13011
Conversation
I rearranged the elements of the left sidebar in HTML in order to appear in the order they are displayed and removed the absolute positioning, because it was not needed if the elements are arranged correctly. I used `flex` display to arrange them on column. I removed the styling that positioned the elements absolutely. Then I tweaked the margins in order to make the elements look good. Fixes: zulip#12929
While refactoring, I tested all the rules and removed the CSS that was
not needed or duplicated.
I removed the `$("#integration-list-link").css('display', 'block');` and
moved it to css because there is no case in which the back link is
hidden.
|
Hello @zulip/server-misc members, this pull request was labeled with the "area: portico" label, so you may want to check it out! |
|
This is great, merged, thanks @alexandraciobica! That said, doing the review of the SCSS migration commit was quite time-consuming; it would have been a lot easier to do if you'd done a series of commits (first one reordering things, then one doing the nesting, and maybe a final one migrating the media queries). In any case, huge thanks for doing all this cleanup on the integrations page CSS; it's a lot nicer of a setup now! |
|
@timabbott sorry for that. I realised that it should be split somehow when I finished and I tried to do it but I somehow broke the branch and had to redo part of the work because I forgot to push the final changes before I started messing with the commits (silly me). I will plan more from the beginning next time. |
Fixes: #12929
The PR also includes:
integrations.scssto use SCSS nestingTesting Plan:
I tested the changes on Chrome and Firefox, on all the screen sizes used in media queries on this page.