stream settings: Use the .show-sender version of email address. #13136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @zulip/server-streams members, this pull request was labeled with the "area: stream settings" label, so you may want to check it out! |
|
|
Fixes zulip#13134 as the last commit in the series for this issue. Solves the "The (?) should just be a target=_blank link to /help/message-a-stream-by-email." part of the issue. As a result, a bunch code managing the email hint popup can be deleted, together with a node test for that.
We intend to use it in the "manage streams" modal as well.
Previously, these were configured as divs.
timabbott
force-pushed
the
email_gateway_stream_address_frontend
branch
from
5684fd9
to
a03ae94
Compare
|
This is great, but the styling should match what we use in settings. I added a few commits to clean up the styling and merged this. Thanks @mateuszmandera! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13134
The first commit just makes the encode/decode test a bit nicer, as said in a short discussion at #12781 (comment)
Then a commit to make the email address displayed in stream settings use
.And finally a change of the (?) thingie as described in the issue.