Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings: Show token for outgoing webhook bot. #13556

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sahil839
Copy link
Collaborator

Bot token is displayed for outgoing webhook bots in the "Your Bots"
section of settings and position of displaying bot type is changed
to top right.

Fixes #12943

Testing Plan:
I have tested it manually and it does not require any changes in already written tests or addition of tests.

GIFs or Screenshots:
Screenshot from 2019-12-19 20-08-03

Bot token is displayed for outgoing webhook bots in the "Your Bots"
section of settings and position of displaying bot type is changed
to top right.

Fixes zulip#12943
@zulipbot
Copy link
Member

Hello @zulip/server-settings members, this pull request was labeled with the "area: settings (user)" label, so you may want to check it out!

@sahil839
Copy link
Collaborator Author

@timabbott please review this PR.

1 similar comment
@sahil839
Copy link
Collaborator Author

sahil839 commented Apr 3, 2020

@timabbott please review this PR.

@zulipbot
Copy link
Member

Heads up @sahil839, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show outgoing webhook bot token in bot settings.
2 participants