users_list: Fix updating of users list on reactivate/deactivate.

[sahil839]

User is added to deactivated users list when user is deactivated from
active users list and it remains in the active users for re-toggle
(in case of mistake) and same happens for reactivating users from
deactivated users list.

Whenever user enters any of the list from somehwhere else, list is
up-to-date.

Fixes #14165

Currently, the last active on reactivation gives Unknown as some change is needed in presence code and issue is opened currently #14279.
I am working on that issue and will soon make a PR.

Testing Plan: This is manually tested.

GIFs or Screenshots:

[showell]

@sahil839 Can you give an update on the status of this PR? I know this issue sort of sent us down the rabbit hole of making sure that we weren't showing the wrong "active" date for users after we reactivated them, but is that actually a blocker for this commit?

[sahil839]

@showell The only problem is that this will show Unknown on reactivation of a user.

[timabbott]

Can you undo the blank line removals here? I think those lines were there for readability, and in any case it's distracting from the rest of the changes in this commit.

[timabbott]

Can you clean up this commit series to have steps like extracting register_click_handlers as a new function as independent commits? It'd be more readable that way.

[sahil839]

@timabbott I have made the changes.
Circle CI failure is unrelated to my changes and is being discussed on CZO.

[showell]

I'm working on a deeper fix here. I'll probably close this PR once I get to a pretty solid point on my branch. Thanks for working on this @sahil839 -- reading your code here has been helpful for me to understand where we can clean this up a bit.

[zulipbot]

Heads up @sahil839, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

[showell]

I haven't quite fixed this yet, but you can see that my recent commits are leading up to a fix here:

https://github.com/zulip/zulip/commits?author=showell

[showell]

In particular the below commit is sort of a preview of how I will split up handling of Users and Deactivated Users, which should help fix this issue:

5c16bb9

There's a little bit of extra work to do, though.

[zulipbot]

Hello @sahil839, it seems like you have referenced #14165 in your pull request description, but you have not referenced them in your commit message description(s). When you reference an issue in a commit message, it automatically closes the corresponding issue when the commit is merged.

Please run git commit --amend in your command line client to amend your commit message description with Fixes #14165..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: zulipbot
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51.

Thank you for your contributions to Zulip!

[zulipbot]

Heads up @sahil839, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.