Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navbar: Fix search input margin. #15193

Merged
merged 1 commit into from Jun 4, 2020
Merged

navbar: Fix search input margin. #15193

merged 1 commit into from Jun 4, 2020

Conversation

majordwarf
Copy link
Collaborator

The commit fixes the spacing between the search icon and the input
field by adding margin-left to the search input field. The following
issue is only visible in dark mode as the nav and search input have
different background color while normal theme uses same background color
for nav and search input.

Testing Plan:
Manually launching running Zulip instance and clicking on navbar.

GIFs or Screenshots:
Before:
image

After:
image

The commit fixes the spacing between the search icon and the input
field by adding `margin-left` to the search input field. The following
issue is only visible in dark mode as the nav and search input have
different background color while normal theme uses same background color
for nav and search input.
@timabbott timabbott merged commit 29b8e11 into zulip:master Jun 4, 2020
@timabbott
Copy link
Sponsor Member

Merged, thanks @majordwarf!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants