[WIP] Implement has: client side filter #15363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timabbott
reviewed
Jun 16, 2020
| } else if (operand === 'attachment') { | ||
| return message.has_attachment; | ||
| } | ||
| return false; // is:whatever returns true |
There was a problem hiding this comment.
I don't think we have to send the data from the server; fundamentally, we can just iterate through the link tags in the HTML via jQuery to do a completely client-side check for each of these.
There was a problem hiding this comment.
Ok I will try that approach.
There was a problem hiding this comment.
@timabbott I am able to detect images, link
but how to distinguish between normal links and attachments like pdf, mp4, etc. ?
Can i rely on checking if /user_uploads/ exist in the href of the anchor tag ?
There was a problem hiding this comment.
Yes, attachment has a very specific meaning: a link to a /user_uploads URL.
thedeveloperr
force-pushed
the
local_has_filter
branch
from
da1d4e7
to
e2b8f74
Compare
Prior to this commit has:link, has:attachment, has:image filter couldn't be applied locally and deferred filtering to web server. This commits make sure client filters all messages it can instead of completely deferring to the server and hence improve speed. A tradeoff is also made to turn off local echo for has: narrows as messages with link sent to has:link narrow were locally echoing to another narrow and not appearing in the active has:link narrow. Fixes: zulip#6186.
thedeveloperr
force-pushed
the
local_has_filter
branch
from
e2b8f74
to
3ac1b95
Compare
|
Closing in favour of #15492 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6186
Testing Plan:
GIFs or Screenshots: