refactor test_message.py into seperate files #15661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedeveloperr
force-pushed
the
refactor_test_message_file
branch
from
9047269
to
5231104
Compare
thedeveloperr
changed the title
thedeveloperr
force-pushed
the
refactor_test_message_file
branch
from
dffae52
to
0887bd9
Compare
|
@timabbott @showell Please review if I am going in right direction. |
thedeveloperr
force-pushed
the
refactor_test_message_file
branch
from
0887bd9
to
81c31cd
Compare
thedeveloperr
changed the title
|
@timabbott @showell Ready for review. There are few other tests which can be split out but I am still figuring out on those. But for now I think these can be merged. |
Starting with extracting out MirroredMessageUsersTests as it is related to mirror users than anything message-specific. In a future commit, may extract out some tests from MessagePOSTTest as well but still deciding on those.
This commit extracts out MessagePOSTTest class from test_messages.py intially. In future commits other related message sending tests will be moved from test_messages.py to test_message_send.py.
….py. The commit moves, test_create_mirror_user_despite_race which is not related to message sending from MessagePOSTTest class in test_message_send.py to test_mirror_users.py.
This commit moves ScheduledMessageTest that tests sending scheduled messages from test_messages.py to test_message_send.py.
StreamMessagesTest test stuff after message is sent to a stream, so moving it out from test_messages.py to test_message_send.py.
This commit moves few tests related to testing proper sending of private messages from PrivateMessagesTest class in test_messages.py to a new class in test_message_send.py.
This commit moves ExtractTest class to test_message_send.py as they test input parsing extract_* functions used in message sending enpoints.
thedeveloperr
force-pushed
the
refactor_test_message_file
branch
from
1553d04
to
f879f09
Compare
This commit moves InternalPrepTest test class to test_message_send.py because it tests internal_send_* and internal_prep_* functions which are used for internal message sending in zulip.
MessageHydrationTest tests hydration done by MessageDict, so moving it out of test_messages.py to test_message_dict.py.
This commit moves TestMessageForIdsDisplayRecipientFetching class which have tests regarding display_recipient filled in by MessageDict to test_message_dict.py.
This commit moves out the SoftDeactivationMessageTest out of test_messages.py (which at the moment have mixed category of tests) into a more logical file, test_soft_deactivation.py.
|
These changes are great, thanks @thedeveloperr! I merged this PR with no changes as the series ending with 98cff4e. For next steps, I think we should:
I believe that list would complete the removal of Thanks @thedeveloperr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://chat.zulip.org/#narrow/stream/3-backend/topic/zerver.2Eviews.2Emessages
Testing Plan:
GIFs or Screenshots: