Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spam from test-backend output #15769

Closed
wants to merge 22 commits into from
Closed

Remove spam from test-backend output #15769

wants to merge 22 commits into from

Conversation

thedeveloperr
Copy link
Collaborator

#1587

Testing Plan:

GIFs or Screenshots:

@zulipbot zulipbot added size: L and removed size: S labels Jul 15, 2020
@zulipbot zulipbot added size: M and removed size: L labels Jul 15, 2020
@zulipbot zulipbot added size: L and removed size: M labels Jul 16, 2020
@zulipbot zulipbot added size: XL and removed size: L labels Jul 18, 2020
@thedeveloperr thedeveloperr changed the title [WIP] Remove spam from test-backend output Remove spam from test-backend output Jul 19, 2020
@thedeveloperr
Copy link
Collaborator Author

@timabbott Please give an initial review on this much work.

@thedeveloperr thedeveloperr force-pushed the remove_test_spam branch 3 times, most recently from e089825 to 587f093 Compare July 20, 2020 22:58
@thedeveloperr
tests: Add assertLogs for warning in test_social_auth_invalid_email.
67b9917 
This commit tests logging of warning log using assertLogs instead of
printing it in test output hence avoiding spam in test output.
@thedeveloperr
tests: Add assertLogs for info logs in test_social_auth_complete.
bdd4b2a 
This commit tests logging of warning log using assertLogs instead of
printing it in test output hence avoiding spam in test output.
@thedeveloperr
tests: Add assertLogs in a test cases related to social auth with ldap.
11d7921 
This commit tests logging of warning and debug logs in code related to
social auth with ldap using assertLogs. So it does not get printed in
the test output hence avoiding spam in the test output.
@thedeveloperr
tests: Verify logging for social authentication of deactivated users.
cf1aee9 
This commit tests logging of info log using assertLogs instead of
printing it in test output hence avoiding spam in test output.
@thedeveloperr
tests: Verify logs for login for non existing realm while using LDAP.
94a2ad9 
This commit tests logging of warning log using assertLogs instead of
printing it in test output hence avoiding spam in test output.
@thedeveloperr
tests: Verify warning logs for SAML social auth for invalid email.
36a1d3c 
This commit tests logging of warning log using assertLogs instead of
printing it in test output hence avoiding spam in test output.
@thedeveloperr
tests: Verify debug logging while login of non existent user in LDAP.
27cd9be 
This commit tests logging of debug log using assertLogs instead of
printing it in test output hence avoiding spam in test output.
@thedeveloperr
tests: Add assertLogs in test_social_auth_session_fields_cleared_corr…
81a881d 
…ectly.

This commit tests logging of info log using assertLogs instead of
printing it in test output hence avoiding spam in test output.
@thedeveloperr
tests: Verify warning log for updating too short user name in ldap.
0e4707c 
This commit tests logging of warning log using assertLogs instead of
printing it in test output hence avoiding spam in test output.
@thedeveloperr
tests: Verify warning log while updating ldap user custom profile field.
f57b34c 
This commit tests logging of warning log while updating ldap user's
custom profile field with invalid data using assertLogs instead of
printing it in test output hence avoiding spam in test output.
@thedeveloperr
tests: Verify warning log while updating ldap user custom profile field.
65671f5 
This commit tests logging of warning log while updating user's custom
profile field  not present in ldap using assertLogs instead of printing
it test output hence avoiding spam in test output.
@thedeveloperr
tests: Verify warning log in test_update_non_existent_profile_field.
4989f1a 
This commit tests logging of warning log while updating ldap user's
non existing custom profile field using assertLogs instead of printing
it in test output hence avoiding spam in test output.
@thedeveloperr
tests: Verify debug log due to domain mismatch LDAP login failure.
341cb6e 
This commit tests logging of debug logs while LDAP login failure due to
domain mismatch using assertLogs instead of printing it in test output
hence avoiding spam in test output.
@thedeveloperr
tests: Verify error logs by log_and_report function.
10b57aa 
This commit verify error logs printed during testing of log_and report
function using assertLogs without printing it in test output and hence
avoiding spam.
@thedeveloperr
tests: Verify logs of incoming webhook profile api key validation.
9909d85 
This commit verify warning logs while testing validate_api_key and
profile is incoming webhook but is_webhook is not set to True.
Verification is done using assertLogs so that logs does not cause spam
by printing in the test output.
@thedeveloperr
tests: Verify logging on error in check_send_webhook_fixture_message.
e4d1161 
This commit tests if error logs are logged when an error occurs during
testing of check_send_webhook_fixture_message using assertlogs. Using
assertlogs ensure logs are not printed as spam in test output.
@thedeveloperr
tests: Verify error logs while data export for zulip.
25401de 
This commit verify that error logging while testing data export in
test_notify_realm_export_on_failure using assertLogs so that the logs
do not spam test output.
@thedeveloperr
tests: Verify error logging of Internal Server Error in simulate_error.
7428a29 
This commits verify error logs while simulate_error simulates an error
using assertLogs so that the logs do not spam the test ouptut.
@thedeveloperr
tests: Verify info logs while testing send_to_email_mirror command.
4a4420d 
This commit tests if info logs are logging using assertLogs so that the
log do not spam the test output.
@thedeveloperr
tests: Make errors stream for ERROR_BOT to report in test_report_error.
0a35414 
ERROR_BOT setting is not None during testing, so running
test_report_error without making errors stream was causing exception.
This commit make a stream name errors thus removes exception and error
log spam caused by it in ./tools/test-backend output.
@thedeveloperr
tests: Verify info logs logging in test_fix_unreads.
f653553 
This commit verifies info logging in test_fix_unreads using assertLogs
so that the logging do not spam ./tools/test-backend output.
@thedeveloperr
tests: Verify error logging in test_push_bouncer_api.
9861937 
This commit verify error logging using assertLogs so logs do not spam
./tools/test-backend output.
@thedeveloperr thedeveloperr mentioned this pull request Jul 21, 2020
Closed
@timabbott
Copy link
Sponsor Member

@thedeveloperr you can potentially go back to this PR now that we've merged most of the prep commits.

@zulipbot
Copy link
Member

Heads up @thedeveloperr, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

@thedeveloperr
Copy link
Collaborator Author

Most of commits from this PR have been merged. Rest are in different PRs so closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
has conflicts size: XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thedeveloperr @timabbott @zulipbot