api: Return 'user_id' in 'POST /users' response. #16107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akashaviator
force-pushed
the
create_user
branch
2 times, most recently
from
9afa1df
to
4c3dcab
Compare
This adds 'user_id' to the simple success response for 'POST /users' api endpoint. Appropriate changes have been made in the docs and test_users.py. Fixes zulip#16072.
akashaviator
force-pushed
the
create_user
branch
from
4c3dcab
to
b42d96b
Compare
|
@orientor This is ready for a review. |
timabbott
reviewed
Aug 11, 2020
| @@ -10,6 +10,11 @@ below features are supported. | |||
|
|
|||
| ## Changes in Zulip 4.0 | |||
|
|
|||
| **Feature level 31** | |||
There was a problem hiding this comment.
I put this in Feature level 30 since we hadn't actually bumped API_FEATURE_LEVEL yet.
|
Merged as 63173d5 after extending the similar API endpoint for creating bots to have the same feature. Thanks @akashaviator! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds 'user_id' to the simple success response for 'POST /users'
api endpoint. Appropriate changes have been made in the docs and
test_users.py.
Fixes #16072.