WIP: Push alerts to screen top and add namespaces to views. #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes push the alerts that were previously in the right sidebar to the top of the screen. Along with that, the namespace of the current view is also added to the <body> element so that you can use CSS to deterministically style a particular view.
|
Automated message from Dropbox CLA bot @brockwhittaker, it looks like you've already signed the Dropbox CLA. Thanks! |
|
@brockwhittaker we still do want to do this migration... are you planning to push a revised version of it? |
|
@timabbott yep, because the main-page-redesign has a different system for settings page position. I'd rather integrate this after we integrate that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes push the alerts that were previously in the right sidebar
to the top of the screen.
Along with that, the namespace of the current view is also added to the
element so that you can use CSS to deterministically style a particular view.A few major things were changed including changing the navbar from a fixed to static position. This means there may be design bugs that I haven’t encountered yet with this.