Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compose: Add support for full-screen compose box #17667

Merged
merged 2 commits into from Jul 7, 2021
Merged

compose: Add support for full-screen compose box #17667

merged 2 commits into from Jul 7, 2021

Commits on Jul 7, 2021

  1. compose: Add support for full size compose box. 

    This commit makes a working toggler in compose_actions that adds the
compose-fullscreen class to the compose that removes the max-height
from the compose textarea and adds flex elements above so that the
height automatically adjust with the device height. This results in
making the compose box full screen sized.

The compose_height.js maintains the state of the height of the compose
box. Also, when the compose box is closed, the compose box is reset to
it's default behaviour and original height. So, everytime user need
not toggle off the compose full size and only for specific message
it is used.

It also adds destroy autosize on compose_height state change.
It destroys the autosize of textarea when the full
screen sized compose box is toggled on. And everytime when it is
turned off, it reinitialises the autosize. This also adds a
condition in autosize_textarea to only autosize when composebox
is not in full height state.

Fixes zulip#17660
    @Signior-X @timabbott
    Signior-X authored and timabbott committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    6cf33c4 View commit details
    Browse the repository at this point in the history

  2. third: Prevent typeahead from going off top of screen. 

    This is by no means the ideal solution, since we are likely to occlude
your cursor, but it prevents the user experience from being clearly
broken.
    @timabbott
    timabbott committed Jul 7, 2021
    Configuration menu
    Copy the full SHA
    98b5f01 View commit details
    Browse the repository at this point in the history