Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Support for extended description box. #18083

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

guptaprakhariitr
Copy link
Collaborator

See previous work here #16905.
Currently, there is no way to view a long description other than the
settings panel. This adds a way via the .extended_narrow_description
box.

#14729.
Testing plan:
Tested Locally.

GIFs or screenshots:
Peek 2021-04-11 01-24

YashRE42 and others added 2 commits April 10, 2021 17:09
Previously, there was no way to view a long description other than the
settings panel. This adds a way via the .extended_narrow_description
box.
Fixes: zulip#14729.
Currently there is no way to see the long descriptions of
a stream. This commit places up/down toggle icons to toggle
between whole description and the starting preview of it.

Fixes: zulip#14729.
@zulipbot zulipbot added size: XL area: search design priority: high UX UX improvements to an existing workflow. labels Apr 10, 2021
@zulipbot
Copy link
Member

Hello @zulip/server-search members, this pull request was labeled with the "area: search" label, so you may want to check it out!

@guptaprakhariitr
Copy link
Collaborator Author

@timabbott This is ready for review.

@timabbott
Copy link
Sponsor Member

@guptaprakhariitr hey, are you up for continuing work on this? I was overwhelmed at the time you opened this PR.

@zulipbot
Copy link
Member

zulipbot commented Sep 7, 2021

Heads up @guptaprakhariitr, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

@alya
Copy link
Contributor

alya commented Oct 18, 2021

I think the visuals are reasonable, and an improvement on the current state (no way to see the description).

Playing around with the PR, I think the description should automatically disappear if the user clicks somewhere outside it after opening it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants