Consistently use self.assert_length in tests.
#18522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijeetbodas2001
changed the title
self.assert_length in tests.self.assert_length in tests.
timabbott
reviewed
May 18, 2021
zerver/lib/test_classes.py
Outdated
| @@ -864,14 +864,14 @@ def assert_json_error(self, result: HttpResponse, msg: str, status_code: int = 4 | |||
| """ | |||
| self.assertEqual(self.get_json_error(result, status_code=status_code), msg) | |||
|
|
|||
| def assert_length(self, items: List[Any], count: int) -> None: | |||
| def assert_length(self, items: Any, count: int) -> None: | |||
There was a problem hiding this comment.
I think you want the appropriate abstract base class, Sized, here.
There was a problem hiding this comment.
Probably Collection, actually, since we do iterate through it.
|
This looks great aside from the type-checking detail there: We never want to use |
Make it so that `assert_length` can be used for not just lists but all `Collections`. This is prep for using this helper consistently for all tests.
This helper does some nice things like printing out the data structure incase of failure.
abhijeetbodas2001
force-pushed
the
assert_length
branch
from
a625701
to
5d907ef
Compare
|
Thanks, fixed to use |
|
Merged, thanks @abhijeetbodas2001! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made with Find&Replace with regex.